Date: Thu, 28 Jun 2012 18:50:04 +0300 (EEST) From: Sayetsky Anton <vsjcfm@gmail.com> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/169523: [patch] x11/xscreensaver: remove forced -O0 from CFLAGS on amd64 Message-ID: <201206281550.q5SFo4np079769@jw.lds.net.ua> Resent-Message-ID: <201206281600.q5SG0PXQ018758@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 169523
>Category: ports
>Synopsis: [patch] x11/xscreensaver: remove forced -O0 from CFLAGS on amd64
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Thu Jun 28 16:00:25 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator: Sayetsky Anton
>Release: FreeBSD 8.3-RELEASE-p1 amd64
>Organization:
>Environment:
System: FreeBSD j.local 8.3-RELEASE-p1 FreeBSD 8.3-RELEASE-p1 #0 r235504: Wed May 16 14:33:18 EEST 2012 root@j.local:/tmp/obj/mnt/garbage/build/src/sys/JASONW amd64
>Description:
>How-To-Repeat:
Update ports and take a look to x11/xscreensaver/Makefile
You will see there the following:
.if ${ARCH} == "amd64"
CFLAGS+= -O0
.endif
There is no need to add "-O0" to CFLAGS on amd64. I've built xscreensaver successfully with "-O2 -fno-strict-aliasing -pipe -march=core2"
>Fix:
--- patch-Makefile begins here ---
--- Makefile-orig 2012-06-28 18:43:01.000000000 +0300
+++ Makefile 2012-06-28 18:43:08.000000000 +0300
@@ -134,10 +134,6 @@
companioncube.6 hilbert.6 tronbit.6 \
xscreensaver-gl-helper.6
-.if ${ARCH} == "amd64"
-CFLAGS+= -O0
-.endif
-
post-patch:
@ ${CP} ${WRKSRC}/configure ${WRKSRC}/configure.Patched
@ ${SED} -e 's#-lpthread#${PTHREAD_LIBS}#g' \
--- patch-Makefile ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201206281550.q5SFo4np079769>