From owner-cvs-src@FreeBSD.ORG Sun Oct 1 17:17:29 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8EEF316A40F; Sun, 1 Oct 2006 17:17:29 +0000 (UTC) (envelope-from mb@imp.ch) Received: from pop.imp.ch (mx2.imp.ch [157.161.9.17]) by mx1.FreeBSD.org (Postfix) with ESMTP id 65AEC43D49; Sun, 1 Oct 2006 17:17:28 +0000 (GMT) (envelope-from mb@imp.ch) Received: from godot.imp.ch (godot.imp.ch [157.161.4.8]) by pop.imp.ch (8.13.8/8.13.8/Submit_imp) with ESMTP id k91HHNjc012787; Sun, 1 Oct 2006 19:17:24 +0200 (CEST) (envelope-from mb@imp.ch) Date: Sun, 1 Oct 2006 19:17:23 +0200 (CEST) From: Martin Blapp To: Alan Cox In-Reply-To: <200609271810.k8RIAGSu022079@repoman.freebsd.org> Message-ID: <20061001191543.M91466@godot.imp.ch> References: <200609271810.k8RIAGSu022079@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-Scanned-By: MIMEDefang 2.57 on 157.161.9.65 Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, re@freesbd.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/amd64/amd64 pmap.c src/sys/i386/i386 pmap.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Oct 2006 17:17:29 -0000 Hi Alan, This commit makes my box crash with HEAD at startup. Please back it out and investige why it happens. I'm pretty sure that it happens for RELENG_6 too. Martin Martin Blapp, ------------------------------------------------------------------ ImproWare AG, UNIXSP & ISP, Zurlindenstrasse 29, 4133 Pratteln, CH Phone: +41 61 826 93 00 Fax: +41 61 826 93 01 PGP: PGP Fingerprint: B434 53FC C87C FE7B 0A18 B84C 8686 EF22 D300 551E ------------------------------------------------------------------ On Wed, 27 Sep 2006, Alan Cox wrote: > alc 2006-09-27 18:10:16 UTC > > FreeBSD src repository > > Modified files: (Branch: RELENG_6) > sys/amd64/amd64 pmap.c > sys/i386/i386 pmap.c > Log: > MFC > Correct a very old and very obscure bug: vmspace_fork() calls > pmap_copy() if the mapping is VM_INHERIT_SHARE. Suppose the mapping > is also wired. vmspace_fork() clears the wiring attributes in the vm > map entry but pmap_copy() copies the PG_W attribute in the PTE. I > don't think this is catastrophic. It blocks pmap_remove_pages() from > destroying the mapping and corrupts the pmap's wiring count. > > This revision fixes the problem by changing pmap_copy() to clear the > PG_W attribute. > > Approved by: re (mux) > > Revision Changes Path > 1.516.2.8 +4 -3 src/sys/amd64/amd64/pmap.c > 1.523.2.8 +5 -3 src/sys/i386/i386/pmap.c >