From owner-freebsd-hackers Mon Sep 18 16:20:53 1995 Return-Path: owner-hackers Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id QAA08764 for hackers-outgoing; Mon, 18 Sep 1995 16:20:53 -0700 Received: from Root.COM (implode.Root.COM [198.145.90.17]) by freefall.freebsd.org (8.6.12/8.6.6) with ESMTP id QAA08757 ; Mon, 18 Sep 1995 16:20:48 -0700 Received: from corbin.Root.COM (corbin [198.145.90.34]) by Root.COM (8.6.12/8.6.5) with ESMTP id QAA18934; Mon, 18 Sep 1995 16:19:28 -0700 Received: from localhost (localhost [127.0.0.1]) by corbin.Root.COM (8.6.12/8.6.5) with SMTP id QAA03724; Mon, 18 Sep 1995 16:21:48 -0700 Message-Id: <199509182321.QAA03724@corbin.Root.COM> To: Terry Lambert cc: kuku@gilberto.physik.rwth-aachen.de, julian@freefall.freebsd.org, hackers@freefall.freebsd.org Subject: Re: why is this not a bug in namei? In-reply-to: Your message of "Mon, 18 Sep 95 14:11:06 PDT." <199509182111.OAA08650@phaeton.artisoft.com> From: David Greenman Reply-To: davidg@Root.COM Date: Mon, 18 Sep 1995 16:21:46 -0700 Sender: owner-hackers@FreeBSD.org Precedence: bulk >> Is this just a typo? Shouldn't it be a FREE() macro like below? ... >The code should still be cleaned up, however. > >I prefer the macroized version to allow later instrumentation. I prefer the non macroized version. The instrumentation of malloc/free belongs in malloc() & free(). Macros are ugly and usually evil. They unnecessarily obscure the code. -DG