From owner-cvs-all Thu Mar 8 17:44:38 2001 Delivered-To: cvs-all@freebsd.org Received: from info.iet.unipi.it (info.iet.unipi.it [131.114.9.184]) by hub.freebsd.org (Postfix) with ESMTP id 1A53437B719; Thu, 8 Mar 2001 17:44:31 -0800 (PST) (envelope-from luigi@info.iet.unipi.it) Received: (from luigi@localhost) by info.iet.unipi.it (8.9.3/8.9.3) id CAA44347; Fri, 9 Mar 2001 02:42:57 +0100 (CET) (envelope-from luigi) From: Luigi Rizzo Message-Id: <200103090142.CAA44347@info.iet.unipi.it> Subject: Re: cvs commit: src/sys/netinet ip_icmp.c ip_input.c In-Reply-To: <200103082152.aa56671@salmon.maths.tcd.ie> from Ian Dowse at "Mar 8, 2001 09:52:45 pm" To: Ian Dowse Date: Fri, 9 Mar 2001 02:42:56 +0100 (CET) Cc: "Rodney W. Grimes" , phk@critter.freebsd.dk, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG X-Mailer: ELM [version 2.4ME+ PL61 (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Rod Grimes noticed that the problem might have to do with the per-address statistic patch (ip_output.c: 1.99.2.11->1.99.2.12 and related patches to ip_output). I suspect it might be that (in the lines involved with this patch) ia becomes null, and also it might happen with icmp packets. Can you put some checks in the code and verify this ? cheers luigi > : > > > >Also this patch doesnt touch ip_output, which is where the panic > >occurs. > > Yes, the two problems look quite different. The hallmark of the > icmp_error bug is a fault address where the two high-bytes have > been swapped (e.g. 0x12c03400), not a NULL deref. > > I haven't managed to match up the short dissassembly posted to > -stable with the ip_output source code yet - do we have any further > details now? > > Ian > > To Unsubscribe: send mail to majordomo@FreeBSD.org > with "unsubscribe cvs-all" in the body of the message > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message