From owner-freebsd-net@freebsd.org Thu Jul 6 21:19:46 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 22176D921B9 for ; Thu, 6 Jul 2017 21:19:46 +0000 (UTC) (envelope-from v.maffione@gmail.com) Received: from mail-wr0-x22a.google.com (mail-wr0-x22a.google.com [IPv6:2a00:1450:400c:c0c::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A54277FDE8; Thu, 6 Jul 2017 21:19:45 +0000 (UTC) (envelope-from v.maffione@gmail.com) Received: by mail-wr0-x22a.google.com with SMTP id r103so20242085wrb.0; Thu, 06 Jul 2017 14:19:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=kEwfBBxHfLOMzPTbQ6nk0kRIKNQ6H4H8TRld7Miyy5Y=; b=W5J9rwa17X3rLiKXCK5b89PqjFoVvMGjqVS5pY45boPFiV2Zo+RmwRLg0xDBTxSY62 vzpJvkWrTwJpXWvKyZaMGkHTg8hAGijMAvRp8LVeszczFH2KrVI/tYClee5kxPx3+v+y ByehI205V9oTiGh3Zmx83gNhRcyQT7ju7YQ5ez1yhE+QY0q1DtxoCaTIlaVL4UW9wT9v ZDUnLjlNbKFCkV4dq3h8gWn4imfT//WoNKoCTaIkNTRrP7DaeerZ+aZC2wfuJsO6pAMk kzhP/36xWw2NLRW7T/TGOMqmErCnTxLDvXUK4YJzrhpDXUXt/Gc/XHGFfcrnlqad3zuC Y2cQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=kEwfBBxHfLOMzPTbQ6nk0kRIKNQ6H4H8TRld7Miyy5Y=; b=qDtx3FhWngTxGbmJsf1DfhulbpIa1U5aMXIMq1cmKNKUGjmYVn/viHdLVDG85oA08o 0Cib8tJBYec0fyi/HJXBL96D2PgXJBkTU0XtmiVYNR/Nk3L9V8BZsFyHJ6WAHAhQauFn dVkok2A8SCdu3deCQ82PGYIYTCLhoQdj2aLs0EEKB/voL4RAjbAH0qbgnGZuy3GU58Ba ss75xRj+CSkEco6yRI8Jv2fZDJW2g213BjDFxXRj1rQWb0fTQWgeuIv4ybYNCnU4jYAa T85dTNpyf6YbZQmB8yvC1Bm6Nreslr8nItEvW7vUmo6rt7SCbbotGIwyLhk6B+l3JBa9 Ldcw== X-Gm-Message-State: AIVw113ccTM7wYF3PMNjo70QvTMqu2amvxXEIABsk+IfPY4fXeRgs8/X 0O/lOQSIu1RY5xWDCaintSuwwCWuWA== X-Received: by 10.28.170.8 with SMTP id t8mr755464wme.111.1499375983444; Thu, 06 Jul 2017 14:19:43 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.99.66 with HTTP; Thu, 6 Jul 2017 14:19:42 -0700 (PDT) Received: by 10.28.99.66 with HTTP; Thu, 6 Jul 2017 14:19:42 -0700 (PDT) In-Reply-To: <20170705110512.GA28058@alchemy.franken.de> References: <20170705110512.GA28058@alchemy.franken.de> From: Vincenzo Maffione Date: Thu, 6 Jul 2017 14:19:42 -0700 Message-ID: Subject: Re: NULL pointer dereference bug triggered by netmap To: Marius Strobl Cc: FreeBSD Net Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Jul 2017 21:19:46 -0000 Sure, can anyone commit this? Il 5 lug 2017 4:05 AM, "Marius Strobl" ha scritto: > On Mon, Jul 03, 2017 at 05:08:09PM +0200, Vincenzo Maffione wrote: > > Details here: > > > > https://github.com/luigirizzo/netmap/issues/322 > > > > Is it acceptable to commit the proposed patch? > > As suggested by hselasky@, the outliner problem at hand is better solved > by a dummy if_start method in order to not hurt the fast-path. Thus, if > anything at all, a KASSERT(ifp->if_start != NULL, "no if_start method") > should be added to if_handoff() and if_start(). > > Marius > >