From owner-freebsd-ports-bugs@FreeBSD.ORG Fri Jul 8 09:50:20 2005 Return-Path: X-Original-To: freebsd-ports-bugs@hub.freebsd.org Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DA82E16A41F for ; Fri, 8 Jul 2005 09:50:20 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 70EC843D4C for ; Fri, 8 Jul 2005 09:50:20 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j689oKdU061009 for ; Fri, 8 Jul 2005 09:50:20 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j689oKl1061008; Fri, 8 Jul 2005 09:50:20 GMT (envelope-from gnats) Resent-Date: Fri, 8 Jul 2005 09:50:20 GMT Resent-Message-Id: <200507080950.j689oKl1061008@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Jeremy Chadwick Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AEEA316A41C for ; Fri, 8 Jul 2005 09:43:29 +0000 (GMT) (envelope-from jdc@parodius.com) Received: from mx1.parodius.com (mx1.parodius.com [64.62.145.229]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6F7A243D45 for ; Fri, 8 Jul 2005 09:43:29 +0000 (GMT) (envelope-from jdc@parodius.com) Received: by mx1.parodius.com (Postfix, from userid 500) id 5826B5F6C; Fri, 8 Jul 2005 02:43:28 -0700 (PDT) Message-Id: <20050708094328.5826B5F6C@mx1.parodius.com> Date: Fri, 8 Jul 2005 02:43:28 -0700 (PDT) From: Jeremy Chadwick To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: ports/83135: sysutils/smartmontools -- Does not work with alternate config location X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Jeremy Chadwick List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Jul 2005 09:50:21 -0000 >Number: 83135 >Category: ports >Synopsis: sysutils/smartmontools -- Does not work with alternate config location >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Fri Jul 08 09:50:19 GMT 2005 >Closed-Date: >Last-Modified: >Originator: Jeremy Chadwick >Release: FreeBSD 4.11-STABLE i386 >Organization: Parodius Networking >Environment: System: FreeBSD pentarou.parodius.com 4.11-STABLE FreeBSD 4.11-STABLE #0: Thu May 12 04:37:52 PDT 2005 root@pentarou.parodius.com:/usr/obj/usr/src/sys/PENTAROU i386 >Description: PREFIX/etc/rc.d/smartd.sh allows for users to set 'smartd_flags' to whatever they want. However, when using your own configuration file (instead of /usr/local/etc/smartd.conf), via smartd_flags="--configfile=/some/place/smartd.conf" ...the following warning is output and smartd does not start: # /usr/local/etc/rc.d/smartd.sh start /usr/local/etc/rc.d/smartd.sh: WARNING: /usr/local/etc/smartd.conf is not readable. This is due to the required_files="/usr/local/etc/smartd.conf" line in smartd.sh. >How-To-Repeat: Set smartd_flags="/some/other/smartd.conf" in rc.conf. Attempt to start smartd via smartd.sh start. >Fix: I've two solutions for this (the latter being recommended); 1. Remove the 'required_files' directive from smartd.sh. My assumption is that if smartd can't find a config file, it'll abort. This is an assumption on my part though. If this is the case, 'required_files' seems superfluous. 2. Add a 'smartd_config' variable to smartd.sh. Set required_files to the value of that, which allows people to use their own configuration file via smartd_config="/some/place/smartd.conf" I think this would be a better solution in the long-run. If the port maintainer does not want/cannot do the work for this, I can submit a patch if asked. I'm being lazy right now. :-) Let me know. >Release-Note: >Audit-Trail: >Unformatted: