From nobody Thu Feb 27 16:55:52 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Z3ct057B0z5qNdD; Thu, 27 Feb 2025 16:55:52 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Z3ct04ZBtz46DL; Thu, 27 Feb 2025 16:55:52 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1740675352; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=icJlXbbqQ041QioJqLhJXqLdtLyzm1SgkROJF0K9dKs=; b=KYNq32mAyoTTDSLOaW7WOXWI6TM9T81cGzyUpXD1OC1WK1Umyt7K03nC3tt1hX9AmG8wgd BnctnAawk9bNikMRWVu74vjbU8B85TzMi0F4FIlYP0H/JhJ1lwj6T1H59W6A/9Wtp5eI0j mMQcAbs+/boqUqzUHCAbHWTTfIeSEhmiFit2UuvWkFmbjN/wWeWJCyU9ka097I7q4Q8UMS ENK9lki1ObuU2JRnVKZvpxpqmp3+Xg6hbeEsOa5I2b1fCiXs7UFOyu+HVXXXzDX9gD31U1 ATX3EDh1MexjY/1xFCi7hTAaXOQe4g51l8BlkO7x2dT7lc0jMIDqGoQACkDUYw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1740675352; a=rsa-sha256; cv=none; b=jd86ZEvbKPPIocHD21vzTr6WkxxU5WkUwEtrJefRVRrEvhicFobCzlboS+GPE5mTazInAj wSNL+Hn6ADBG5etjnL7Ckdqv6q8sWt0RnPs2AhSLTpaGG2Gp9AEnStLyfGqTYplze0iJIf UaYD2a9pQ+gGR7HVvrtMbZN1NzYohfOvKqlZonmBpmRvCpIvd3ePTqGSXc2VxSLV9+jZRW pxCl9r7ikVPGkkBfXNZt/JJPTmYn8Ry7y2RQ6ChrbZF95yJtCx3bn70h1mw7Zc6guztQq8 at3SgCFYUrysW56eiIWHPT39kbk9kn+NaDaX+c8gcbk8bcDwDLjmKsGJgvZs7Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1740675352; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=icJlXbbqQ041QioJqLhJXqLdtLyzm1SgkROJF0K9dKs=; b=Coi2utF2Qh3aiq8vFfbz86CzvErZCBT+UXQR7QhIWsdppEw/mr7VBf2HQMDt7lFcQsScCJ hUoZGUKdAFT75npwzPKugYaks3JjaFYnFKrwBDTNEKyCqLcWXxRxfWlrUOXRqVTdqfmHog 4Uh/4z2SD/ivde2Ei36GXygKh6mVQl0oGdp3K0xK25PbYa2V3K5MVUTG5vu9dpgCE3BaM8 055g8q2yjGWulEUyZdX9SBYnEgyJbi3Q1UX7399Ou8es/wcHljYxB53JGV+Y3swCY0BuRl UQifvs5HAl/k5/SNSadiFEBwwis6gq5KR9/xKczWvbD3ff4PGVvKN8VZcOthCA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Z3ct042jszrtr; Thu, 27 Feb 2025 16:55:52 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 51RGtqJT016952; Thu, 27 Feb 2025 16:55:52 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 51RGtqn3016949; Thu, 27 Feb 2025 16:55:52 GMT (envelope-from git) Date: Thu, 27 Feb 2025 16:55:52 GMT Message-Id: <202502271655.51RGtqn3016949@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: John Baldwin Subject: git: 2266614d0714 - stable/14 - hifn/safe: Remove dummy calls to bus_generic_detach List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhb X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 2266614d0714ae78b693b450832c48d73cfc0404 Auto-Submitted: auto-generated The branch stable/14 has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=2266614d0714ae78b693b450832c48d73cfc0404 commit 2266614d0714ae78b693b450832c48d73cfc0404 Author: John Baldwin AuthorDate: 2024-11-05 01:31:30 +0000 Commit: John Baldwin CommitDate: 2025-02-27 15:18:05 +0000 hifn/safe: Remove dummy calls to bus_generic_detach These drivers do not add child devices, so there's no need to try to detach children. Reviewed by: imp Differential Revision: https://reviews.freebsd.org/D47390 (cherry picked from commit 8b54d874c70d9fb3ed2e059f65c91b3e0eaadbd7) --- sys/dev/hifn/hifn7751.c | 2 -- sys/dev/safe/safe.c | 1 - 2 files changed, 3 deletions(-) diff --git a/sys/dev/hifn/hifn7751.c b/sys/dev/hifn/hifn7751.c index 23cf019b93a6..2e7545779b09 100644 --- a/sys/dev/hifn/hifn7751.c +++ b/sys/dev/hifn/hifn7751.c @@ -637,8 +637,6 @@ hifn_detach(device_t dev) crypto_unregister_all(sc->sc_cid); - bus_generic_detach(dev); /*XXX should be no children, right? */ - bus_teardown_intr(dev, sc->sc_irq, sc->sc_intrhand); /* XXX don't store rid */ bus_release_resource(dev, SYS_RES_IRQ, 0, sc->sc_irq); diff --git a/sys/dev/safe/safe.c b/sys/dev/safe/safe.c index da2afbd38fad..c512f3fc62c0 100644 --- a/sys/dev/safe/safe.c +++ b/sys/dev/safe/safe.c @@ -464,7 +464,6 @@ safe_detach(device_t dev) mtx_destroy(&sc->sc_ringmtx); safe_dma_free(sc, &sc->sc_ringalloc); - bus_generic_detach(dev); bus_teardown_intr(dev, sc->sc_irq, sc->sc_ih); bus_release_resource(dev, SYS_RES_IRQ, 0, sc->sc_irq);