From owner-cvs-all Sat Oct 6 12:17:25 2001 Delivered-To: cvs-all@freebsd.org Received: from kayak.xcllnt.net (209-128-86-226.bayarea.net [209.128.86.226]) by hub.freebsd.org (Postfix) with ESMTP id 2387D37B406; Sat, 6 Oct 2001 12:17:01 -0700 (PDT) Received: (from marcel@localhost) by kayak.xcllnt.net (8.11.4/8.11.4) id f96JGs068261; Sat, 6 Oct 2001 12:16:54 -0700 (PDT) (envelope-from marcel) Date: Sat, 6 Oct 2001 12:16:54 -0700 From: Marcel Moolenaar To: Bruce Evans Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/ia64/include cpufunc.h Message-ID: <20011006121654.B68233@kayak.xcllnt.net> References: <200110060931.f969ViC77564@freefall.freebsd.org> <20011006224619.X1107-100000@delplex.bde.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20011006224619.X1107-100000@delplex.bde.org> User-Agent: Mutt/1.3.22.1i Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sat, Oct 06, 2001 at 10:57:48PM +1000, Bruce Evans wrote: > On Sat, 6 Oct 2001, Marcel Moolenaar wrote: > > > marcel 2001/10/06 02:31:44 PDT > > > > Modified files: > > sys/ia64/include cpufunc.h > > Log: > > o Change ia64_memory_address to explicitly take a u_int64_t > > o Add memcpy_fromio, memcpy_io, memcpy_toio, memset_io, > > memsetw and memsetw_io. I'm not sure this is the right > > place for it, though. > > Certainly not. As the comment near the beginning says says, cpufunc.h > is "to provide access to special ${MACHINE_ARCH} instructions". It should > not contain anything that can be written in C, including anything that > can be written in C by combining primitives written in inline asm. I thought so. What is the right place, then. It seems that bus_memio.h is a good match, but that file is empty for all ports and thus is making me nervous. The other logical place is bus.h. On alpha the functions are there, but that's mostly because of the implementation. -- Marcel Moolenaar USPA: A-39004 marcel@xcllnt.net To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message