From owner-svn-src-all@freebsd.org Sat Nov 7 16:49:52 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 34C4BA28AE8 for ; Sat, 7 Nov 2015 16:49:52 +0000 (UTC) (envelope-from mailing-machine@vniz.net) Received: from mail-lb0-f179.google.com (mail-lb0-f179.google.com [209.85.217.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id BCCCA1A88 for ; Sat, 7 Nov 2015 16:49:51 +0000 (UTC) (envelope-from mailing-machine@vniz.net) Received: by lbbwb3 with SMTP id wb3so75797883lbb.1 for ; Sat, 07 Nov 2015 08:49:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=8QzmZlOkICxaoFh4VYk1a5fUDl8tk8EoB60/7IaUvec=; b=iei+n7El+GWatNUjh0HhfUis9XUHBIgTx1EyrdVKHNRuuZwaJGfJFoEejrz1TfIRS5 1jBQXFhFISEjEyu3IXkvS4NFA7OzG1AhoBJ08oIpDU2pbKyFvCsbYZ5FRjXOvyr0gZ8G fXBKK96Cjm0VEQz4o/99q95iXC2o0xjzwfwznsjkcZx0fUnb6EyvnrfvYcmo4vMMf6Dd mOAVrY0xfDZ7uAwzO3MPsYHWGPuGi+sBN8LMct1pH14eDv1ZaprGrD+53vWzumqCCWqV lH95ih9NI4d9jYUKW14hMwiev6GkocczHft519rsdcNdy99fdVjJnKCmabEbhCw44gTB x3rg== X-Gm-Message-State: ALoCoQnjwYpySuVW3hLVN5cuo4dTJHjgK2nY38WY+YflsxkmHb0728P4f98DM5nBmEW4FjtYmTi7 X-Received: by 10.112.168.194 with SMTP id zy2mr10100542lbb.79.1446914984009; Sat, 07 Nov 2015 08:49:44 -0800 (PST) Received: from [192.168.1.2] ([89.169.173.68]) by smtp.gmail.com with ESMTPSA id b142sm934655lfb.46.2015.11.07.08.49.42 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 07 Nov 2015 08:49:43 -0800 (PST) Subject: Re: svn commit: r290499 - head/usr.bin/localedef To: Baptiste Daroussin , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201511071622.tA7GMTDN099727@repo.freebsd.org> From: Andrey Chernov Message-ID: <563E2BA6.9020505@freebsd.org> Date: Sat, 7 Nov 2015 19:49:42 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <201511071622.tA7GMTDN099727@repo.freebsd.org> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 Nov 2015 16:49:52 -0000 On 07.11.2015 19:22, Baptiste Daroussin wrote: > Author: bapt > Date: Sat Nov 7 16:22:29 2015 > New Revision: 290499 > URL: https://svnweb.freebsd.org/changeset/base/290499 > > Log: > Workaround an issue on i386 to unbreak the build until the real issue is tracked > down > - large = calloc(sizeof (collate_large_t) * n, 1); > + large = malloc(sizeof (collate_large_t) * n); > + memset(large, 0, sizeof (collate_large_t) * n); Should be calloc(n, sizeof (collate_large_t)) according to calloc usage and to prevent size_t overflow. Is it calloc() bug? -- http://ache.vniz.net/