From owner-freebsd-wireless@FreeBSD.ORG  Fri Nov  8 08:03:05 2013
Return-Path: <owner-freebsd-wireless@FreeBSD.ORG>
Delivered-To: freebsd-wireless@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id DCCCC210
 for <freebsd-wireless@freebsd.org>; Fri,  8 Nov 2013 08:03:05 +0000 (UTC)
 (envelope-from adrian.chadd@gmail.com)
Received: from mail-qc0-x232.google.com (mail-qc0-x232.google.com
 [IPv6:2607:f8b0:400d:c01::232])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id A152B2708
 for <freebsd-wireless@freebsd.org>; Fri,  8 Nov 2013 08:03:05 +0000 (UTC)
Received: by mail-qc0-f178.google.com with SMTP id x19so1432878qcw.37
 for <freebsd-wireless@freebsd.org>; Fri, 08 Nov 2013 00:03:04 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:sender:in-reply-to:references:date:message-id:subject
 :from:to:content-type;
 bh=qYgK1rtivvDGN3T0Zjw3mp4f/S74eZ56ayti69YMokU=;
 b=lTcXSjl+0eLWP8OO4qlo4FEv15HO+rL7ElA/zy5UNEk9pdHqUmXRRsGg16F2wMXldp
 u+SwYWtlXvVpDRCyCg7yDxfFnDX0a802widrrZmREL/C7ntG9UEK5QI4L7/Lm4Ay5y+v
 FiEhPgCibVtiQ0tmHtBIEwMhVeFKBgV/rcfVBF+x37DHPOyI6/GxLXq6SESnlSH887m4
 uUN98q45zE9zSFJEPTh8RK0wyYLQPj8e3Xvx3+Qz/n7jlC8RKziYJgEgqKgFl+Cv2L+7
 N4Elkz+bD1TxB5GuXNlRB6baDi5Ug+VyA4Z4kmRFZSeky1sxU0nzHRFo1S3up+wwV1nd
 H0nQ==
MIME-Version: 1.0
X-Received: by 10.224.36.201 with SMTP id u9mr21416784qad.76.1383897784789;
 Fri, 08 Nov 2013 00:03:04 -0800 (PST)
Sender: adrian.chadd@gmail.com
Received: by 10.224.207.66 with HTTP; Fri, 8 Nov 2013 00:03:04 -0800 (PST)
In-Reply-To: <CAJ-VmokfBtii5hXhbn_LPJKXXhLvB9wkvQ-qDwQOW3B5DoiNLw@mail.gmail.com>
References: <CAJ-VmokfBtii5hXhbn_LPJKXXhLvB9wkvQ-qDwQOW3B5DoiNLw@mail.gmail.com>
Date: Fri, 8 Nov 2013 00:03:04 -0800
X-Google-Sender-Auth: TvTMd2zYmtyfSXQIn7122jjd7WA
Message-ID: <CAJ-Vmokuqp4cdD3aq2J8utd6McvQG7b47rtZ4k7woAN0ag_Snw@mail.gmail.com>
Subject: Re: [iwn] round two - 5100 works, but 2xxx doesn't
From: Adrian Chadd <adrian@freebsd.org>
To: "freebsd-wireless@freebsd.org" <freebsd-wireless@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
X-BeenThere: freebsd-wireless@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "Discussions of 802.11 stack,
 tools device driver development." <freebsd-wireless.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-wireless>, 
 <mailto:freebsd-wireless-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-wireless>
List-Post: <mailto:freebsd-wireless@freebsd.org>
List-Help: <mailto:freebsd-wireless-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-wireless>, 
 <mailto:freebsd-wireless-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 08 Nov 2013 08:03:05 -0000

.. I compared it to cedric's driver (after I made it compile on
-HEAD). Lo and behold, I realised a bunch of stuff in iwn_config()
wasn't being run.

Damned missing braces.

http://people.freebsd.org/~adrian/iwn/20131107-iwn-update-works-full-5100-2230-10.diff

This works on the 5100 and the Centrino 2230 NICs. I haven't yet
tested the rest.



-adrian