From owner-freebsd-stable@freebsd.org Fri May 11 18:32:06 2018 Return-Path: Delivered-To: freebsd-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 97ACAFC375D for ; Fri, 11 May 2018 18:32:06 +0000 (UTC) (envelope-from vrwmiller@gmail.com) Received: from mail-vk0-x233.google.com (mail-vk0-x233.google.com [IPv6:2607:f8b0:400c:c05::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 2854B6D649; Fri, 11 May 2018 18:32:06 +0000 (UTC) (envelope-from vrwmiller@gmail.com) Received: by mail-vk0-x233.google.com with SMTP id e67-v6so3523965vke.7; Fri, 11 May 2018 11:32:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MfeKm5j9bVgwTYvQNaQZhWbdAYDms5PDIIDWLrs9s+k=; b=rRGtnkrIqirVCkrvk0EmWCBDLjeVlEIhS9DFMsqDGaZnMqi97XYi51ZpKoO0Tj7Q+J TSbC+J7xemFyCUKpE9FDYWMrJMty21DgMVVlSXdi0CiowqsmBcUSfR9Tkfe4/batSsGn 4fO+cEr/b4UbtpF9XcJoRpHkAaHFivi81u7H+F028RgMdxvFketk29mF9GWd0yHsDwDw YEXSddXysouErRFkKtLPj0DKhDuVnON60O7YunBCRm6Yh/RtCZIIhG9UQcRYEaeLLzmn fHVbODDBMk8UnHUP2o00z4vzeeYwXUvvb7cYWso71+CIvcUDyIHq4PiRQX/kJnaz6aOR lLYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MfeKm5j9bVgwTYvQNaQZhWbdAYDms5PDIIDWLrs9s+k=; b=DZUp2sby++c/gX05IvsrQ/QoufveWWAf8u5Ig5nsbMOsisafh+9+0ZzmgrmHgmQk8/ yFAgiRohk6iTW4ZjX9rqWjfzyts7VeE7QmRXQ+0PMkqRp58qVaubZ7YYh55Chv3uueDG xb+dDpLFmmFdNNmOPz4baG2nAZbIof0uUJyHwksLs4woPI5lIjQD5EN4rrlwqRPSWCX8 nu2IoQs6sPGNGbjHdDZMeLrGdJDclUd06anCsVdm/Wx9kAsXptiMfe77NqL/ea4wcIyp XMkSR/1y5UyACppuVEL/QLOhknOMncJrILrtmODjSyrkF0cYwfCj1YqdLn3GWvxCTStF +iqA== X-Gm-Message-State: ALKqPwfRCOsI0VtN925yIvETKisO65c9Gt28Shfj6qshTpR/FTDC3er5 7GoFgYqAUyJT6Thqd2/HHCc12PiL4HpQXVFGXEg= X-Google-Smtp-Source: AB8JxZoDGrExitARK0QxL3Zl8ljc0xIAbEdy8F0evHde2k6H5xpW2JyarEPglttl7u030RTtwKDC+14FBN2YYbDoeIs= X-Received: by 2002:a1f:a193:: with SMTP id k141-v6mr2086114vke.27.1526063525350; Fri, 11 May 2018 11:32:05 -0700 (PDT) MIME-Version: 1.0 References: <4AC438CE-A49C-458E-A989-B145A4FBAA15@FreeBSD.org> <1525966070.35372.60.camel@freebsd.org> In-Reply-To: <1525966070.35372.60.camel@freebsd.org> From: Rick Miller Date: Fri, 11 May 2018 14:31:54 -0400 Message-ID: Subject: Re: lint errors in stable/11 To: Ian Lepore Cc: Dimitry Andric , "freebsd-stable@freebsd.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 May 2018 18:32:06 -0000 On Thu, May 10, 2018 at 11:27 AM Ian Lepore wrote: > On Thu, 2018-05-10 at 14:40 +0000, Rick Miller wrote: > > On Thu, May 10, 2018 at 8:23 AM Dimitry Andric wrote: > > > > > > > > On 10 May 2018, at 12:47, Rick Miller wrote: > > > > > > > > > > > > On Thu, May 10, 2018 at 6:35 AM Rick Miller > wrote: > > > ... > > > > > > > > > > > > > > Performing a release build via release/release.sh in r331337 of > > > stable/11 > > > > > > > > > > > > > > errors citing the lack of lint. It=E2=80=99s understood lint was = removed > from > > > > > stable/11 so src.conf includes WITHOUT_LINT, but errors persist. > As the > > > > > code review alludes to[1], lint is irrelevant here. It seems > > > WITHOUT_LINT > > > > > > > > > > > > > > may not be the only thing I=E2=80=99m looking for. What is the be= st > approach for > > > > > mitigating these errors? > > > > > > > > > > > > > > Here=E2=80=99s the error w/o email munging: > > > > > > > > =3D=3D=3D> usr.bin/xlint/xlint (all) > > > > /data/dists/11.1.9.0-amd64-md/usr/src/contrib/apr/atomic/uni > > > > x/builtins.c:71:53: > > > > warning: passing 'const void *' to parameter of type 'volatile void > *' > > > > discards > > > > qualifiers [-Wincompatible-pointer-types-discards-qualifiers] > > > > > > > > return (void*) __sync_val_compare_and_swap(mem, cmp, with); > > > > > > > > ^~~ > > > > > > > > 1 warning generated. > > > > > > > > =3D=3D=3D> usr.bin/xlint/llib (all) > > > > > > > > sh: lint: not found > > > Are you building on a -CURRENT host? If so, see the previous mail > > > thread about this: > > > > > > > > > > https://lists.freebsd.org/pipermail/freebsd-stable/2017-November/088092.h= tml > > > > > > and https://bugs.freebsd.org/223892. > > > > > > No, the build system is stable/11 r331337 building releng/11.1. The > build > > system doesn=E2=80=99t include =E2=80=98lint=E2=80=99: > > > > # echo $PATH > > /sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin:/root/bin > > # which lint > > lint: Command not found. > > > > The mail thread and bug refer to building stable/11 on current where th= is > > case is building releng/11.1 on stable/11. They also do not appear to > > provide actionable information on mitigating errors though the code > > commit[1] suggests installing a lint will resolve. Ports doesn=E2=80=99= t seem to > > contain a suitable replacement however. Can lint still be installed on > the > > build system from the stable/11 source? If so, how is that accomplished= ? > > > > Do WITH/WITHOUT_LINT have any impact here? The source has been built wi= th > > WITH_LINT and WITHOUT_LINT to the same result except that xlint either > > builds or doesn=E2=80=99t depending on the option. > > > > This all seems to originate with llib=E2=80=99s dependency on lint as d= escribed > in > > the email thread. It is in building llib where the error occurs. > > > > [1] https://reviews.freebsd.org/D13799=EF=BB=BF > > > > -Rick > > Releng/11.1 is cast in stone; as I understand it, only security fixes > can get merged into release branches, so the fix I did that added > WITH/WITHOUT_LINT isn't on that branch and never will be. That means > lint has to exist on the build system. If your build system is 11- > stable, then add WITH_LINT=3Dyes to your /etc/src.conf, build and install > world, then that 11-stable system should be able to build the releng > branch. Unfortunately, no such option exists for people trying to build > on 12, because lint was removed completely (although it might be > possible to install a lint port, I'm not sure about that). > Thanks for the information! src.conf now includes WITH_LINT=3D=E2=80=9CYES=E2=80=9D and buildworld succ= eeds and produces the =E2=80=98xlint=E2=80=99 that ultimately is installed via installworld: # grep LINT /etc/src.conf WITH_LINT=3D"YES" # pwd /usr/obj/usr/src/usr.bin # find . -name '*lint' -type f ./xlint/xlint/xlint # Observe below in this error where =E2=80=98xlint=E2=80=99 is installed as /= usr/bin/lint, but installworld still fails citing lint is not found. Creating symlink /usr/bin/lint to /usr/bin/true seemed to have no impact on results. =3D=3D=3D> usr.bin/xlint (install) =3D=3D=3D> usr.bin/xlint/lint1 (install) install -s -o root -g wheel -m 555 lint1 /usr/libexec/lint1 install -o root -g wheel -m 444 lint1.debug /usr/lib/debug/usr/libexec/li= n t1.debug install -o root -g wheel -m 444 lint.7.gz /usr/share/man/man7/ =3D=3D=3D> usr.bin/xlint/lint2 (install) install -s -o root -g wheel -m 555 lint2 /usr/libexec/lint2 install -o root -g wheel -m 444 lint2.debug /usr/lib/debug/usr/libexec/lint2.debug =3D=3D=3D> usr.bin/xlint/xlint (install) install -s -o root -g wheel -m 555 xlint /usr/bin/lint install -o root -g wheel -m 444 lint.debug /usr/lib/debug/usr/bin/lint.de bug install -o root -g wheel -m 444 lint.1.gz /usr/share/man/man1/ =3D=3D=3D> usr.bin/xlint/llib (install) lint -cghapbx -I/usr/obj/usr/src/tmp/usr/include -Cposix /usr/src/usr.bin/xlint/llib/llib-lposix make[6]: exec(lint) failed (No such file or directory) *** Error code 1 Stop. make[6]: stopped in /usr/src/usr.bin/xlint/lib *** Error code 1 -Rick --=20 Take care Rick Miller