From nobody Fri Oct 22 16:06:52 2021 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id F0415181AFDD for ; Fri, 22 Oct 2021 16:06:54 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4HbTkQ5pkwz4TgR; Fri, 22 Oct 2021 16:06:54 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from John-Baldwins-MacBook-Pro.local (ralph.baldwin.cx [66.234.199.215]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4C5B226A8; Fri, 22 Oct 2021 16:06:54 +0000 (UTC) (envelope-from jhb@FreeBSD.org) To: marklmi@yahoo.com, "bapt@freebsd.org" , freebsd-current References: <5270B5FE-6C3B-4172-A310-AE9A5A1B853A.ref@yahoo.com> <5270B5FE-6C3B-4172-A310-AE9A5A1B853A@yahoo.com> From: John Baldwin Subject: Re: main changed DIALOG_STATE, DIALOG_VARS, and DIALOG_COLORS but /usr/lib/libdialog.so.? naming was not adjusted? (crashes in releng/13 programs on main [so: 14] can result) Message-ID: Date: Fri, 22 Oct 2021 09:06:52 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 In-Reply-To: <5270B5FE-6C3B-4172-A310-AE9A5A1B853A@yahoo.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-ThisMailContainsUnwantedMimeParts: N On 10/22/21 1:08 AM, Mark Millard via freebsd-current wrote: > main [soi: 14] commit a96ef450 (2021-02-26 09:16:49 +0000) > changed DIALOG_STATE, DIALOG_VARS, and DIALOG_COLORS . > These are publicly exposed in (ones that I noticed): > > /usr/include/dialog.h:extern DIALOG_STATE dialog_state; > /usr/include/dialog.h:extern DIALOG_VARS dialog_vars; > /usr/include/dialog.h:extern DIALOG_COLORS dlg_color_table[]; Then we need to bump libdialog's so version to 10? (I don't think libdialog has symbol versioning) -- John Baldwin