From nobody Mon Apr 20 17:20:23 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fzsgw6TBjz6ZCqJ for ; Mon, 20 Apr 2026 17:20:28 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fzsgw2r7Bz3VgH for ; Mon, 20 Apr 2026 17:20:28 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1776705628; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=AZn6rRrANkLkLu+7ON1PWeeHI6NQvnOufxbB2xtSqr4=; b=RKsLlNeGFtABq2rBwrw3P3MoC+5l/2DXI+SQ85C9cJV/bEdBErZ487uVBvQpaBkXrz3B93 SW/P+v6LksrguEfVT+N0pE9eyqW/EUtCd9slFcUACThmFZhPKhzfS7e0WrfbehCykLmTKb foIMIPg/GgWaGEvlHMmj650dfDhpZ7G8MDhvWGsQ19im+2Z+X1l3tNuvsBgw+KoW0h0AoI qi/UEceWnVP312+Z+x9eXfwwAaSFiZcWJo0qwf47lST4EcWrs/ZL/SZKBetTJxb/KXFQmm hhkAf54MiuS7hiqzocIbRoB59fEuwTT527FqPEzT+BBnxaVm94VKr7cKAgOncQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1776705628; a=rsa-sha256; cv=none; b=OkgL0FL3kzSP2aDheCXlqczxBCc4vl4j/AN27fC/3VudH8aJw7YioMAfhKrhTTSN9NpOkw U50eFtcVM6Cy6xzJ7mxKoTKcmVVwJxcRIzgC0j6mXC+K69jUvG1zQ2mkmJzJjxrHvpmWVR jFVlQ6hZQhOWIOFSKTEeT8Xh4t/LAu8Lw1Nyd6FA3APjIrfOy44FUazGfuqDeUfQ2rRCbR T0h9JDnQMfcffcVROq8OXyB76m86/rHp9MGeDIHmaiDORkHybpuXWW10HNenOo0H29xg/x Tu2QG0CD61WezWwgPGq1blANJUTRKcy8NS997CS/ZDo51praKvO3RXCTbVD24w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1776705628; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=AZn6rRrANkLkLu+7ON1PWeeHI6NQvnOufxbB2xtSqr4=; b=Ylq+rdfT5YzE9OJQxxmnztvBv91858H4IBjjeO2770GkKDVQciOq3Qyvkfzp8Z8gXhLC4Q bAV3rdGYRW2W59dPr9H1sI0ysqNbaKkCSKeXyOjd2FEszqJIxB+M/wMAQttjbNj9KQ10bl r2Hk+9/nftjL78T0Roi3MQig8zCRr+NhqmxuX4+N42mqhrRqLRI1aMYV+cGzddKyGUGzm3 JxpgslijALIjYOZ72KzcIo+0LLo8Re6wLho1tUgtCx3jWracJ0uK0d6sa+j3YuVvasQACh eI/sOeyOSxP6oBibt79qYJtP0Af8J5L9cd4sqWxXwh4pGnPDx+AqSA4EYu6Rfw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fzsgw2JgXz15bk for ; Mon, 20 Apr 2026 17:20:28 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3f615 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 20 Apr 2026 17:20:23 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: John Baldwin Subject: git: 505f381cb96e - main - nvmf_che: Don't leak a socket if an error occurs finalizing the socket List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhb X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 505f381cb96ee25bcf0df11cfaf15a601d969500 Auto-Submitted: auto-generated Date: Mon, 20 Apr 2026 17:20:23 +0000 Message-Id: <69e66057.3f615.57d6933e@gitrepo.freebsd.org> The branch main has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=505f381cb96ee25bcf0df11cfaf15a601d969500 commit 505f381cb96ee25bcf0df11cfaf15a601d969500 Author: John Baldwin AuthorDate: 2026-04-20 17:18:04 +0000 Commit: John Baldwin CommitDate: 2026-04-20 17:18:04 +0000 nvmf_che: Don't leak a socket if an error occurs finalizing the socket If soreserve() or sosetopt() (to set TCP_NODELAY) fails after claiming the socket from the file descriptor, explicitly close the socket before returning failure. Sponsored by: Chelsio Communications Differential Revision: https://reviews.freebsd.org/D55493 --- sys/dev/cxgbe/nvmf/nvmf_che.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sys/dev/cxgbe/nvmf/nvmf_che.c b/sys/dev/cxgbe/nvmf/nvmf_che.c index afdfc2f1b758..be54e7bebfea 100644 --- a/sys/dev/cxgbe/nvmf/nvmf_che.c +++ b/sys/dev/cxgbe/nvmf/nvmf_che.c @@ -2605,6 +2605,7 @@ che_allocate_qpair(bool controller, const nvlist_t *nvl) free(qp->fl_cids, M_NVMF_CHE); free(qp->open_fl_ttags, M_NVMF_CHE); free(qp, M_NVMF_CHE); + soclose(so); return (NULL); }