From nobody Tue Mar 3 11:25:48 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fQD575YV8z6SycN for ; Tue, 03 Mar 2026 11:26:03 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-pj1-x102e.google.com (mail-pj1-x102e.google.com [IPv6:2607:f8b0:4864:20::102e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fQD571HhHz3VCk for ; Tue, 03 Mar 2026 11:26:03 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-pj1-x102e.google.com with SMTP id 98e67ed59e1d1-354bc7c2c46so3105691a91.0 for ; Tue, 03 Mar 2026 03:26:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1772537160; cv=none; d=google.com; s=arc-20240605; b=lDzgLLTXJw8G4HX7EEI1k5kOiAKFiV6tIT7RN/V0O6/T2O2zi8t6R5yh1WOVR4QU4k Pk4ekRkH6A8f0Isr2t/mG2VS2Fy9FhA4h/0CLFgmwaBRIIawB1LL1h5mVHagF8lDfgKn ry8Uo5LU5zkofNmrOIAGcSoueUYkamsonF1+Afbf+C15n1tVPKZ5a1FEdHNSb8GWIFUe 3cdHvbI0NspirQAQKXCmykLCjBY3QPTbmXqvHA0qqITM9vdRoSNMyuW5TArr8AQgEl5b Y+hiZYLClC7CwdDOPZI6v3It9UAjVj8PBEN+WPyhN4P+TB1+VdIhSVoKE7g8muvZ7QBN WLUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=Bx+AO1lVryOD0R/NWm8A9HkRHnoZGy+fUGBNuB9w+rk=; fh=yB5D+XPt8GRnMMeup8Qb/cx6rCQrP/FKjqB3mXqUYsw=; b=Kh9Wa5+RjVp3HvN8LHjfXO9Dt9Mg0cJYlO4lfIANJGhzZnhmpYE1RFqfcRNqIOtfr1 u12DIy/722/sxi6y//hiTGj+q3guZrNJL6gxGKHK0QCagts3wNwibInjxXnBjxXWDzld i2/Is6mR/Ij6w316KOQ+DcLsxgvvk/fiBZLr9DTPcld47MARRGSL+9vtMKwE1xFCa2QK 3MkNmSDwTrL6sz3i8fCY1co0hN5KE2/zlXwB/SSP8xhG8KF5k4GRCPlS1IsYieMsIhmR KtWGHvZ6LhIlxdx6f2pnIwdLkepviH+iNksVpd0MMMp854eWivRit9R2EG88YhIjab9a XRZg==; darn=freebsd.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20230601.gappssmtp.com; s=20230601; t=1772537160; x=1773141960; darn=freebsd.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Bx+AO1lVryOD0R/NWm8A9HkRHnoZGy+fUGBNuB9w+rk=; b=i7FmGWgBIxFIKKXCDbdrIqaypqa2G9znwdSOdPAOuys8hvR3drUIKZSnOwU15x0mPy 0IYwHIAFmAA5R1b4VJdcAFU9mBH9dxOUdLCoCFohYNqdNO+GuroM2+/a7Rb0uDqRzcwC O7QhIT4u8zGcp1H7WGslH1Z5mKlOIaOvU9Ml2//jMRVhhEysTSIxPEBt+tFUfrkApMI1 Bt7nGyr7cxDEuMD+/MonBffytKkFORJgvJU7JrlJ/0qOchavAhrcjQPWl/4nUrFnJN2t H7mxudz4tIlZsKioFlpStUvA0jjA//+d106rYekPOLwvVJwN0oaQalyGpcbVEzw1vXZx YXDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772537160; x=1773141960; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Bx+AO1lVryOD0R/NWm8A9HkRHnoZGy+fUGBNuB9w+rk=; b=OsjR3SAhk8k6fANug4UsznejTatvAoCfNLW/fDirvVJI2dcGiiGArr4X4FdOfFcHqu OTPnWDPSuebicG9GqAnTr67On7q7WMTiJr4jokp1bVoPLG95isV1bN1SPwV+IgO1fTj8 yW3+c/iE+p12S6Z4QQFGJEEJA8FswIh4IKvEegwSLzYJ1bkvWZrGnOKErbZ/CGg9gL5d AwYRd1XnWkmUZFI9gxBkE7NHNXl5Fxrhy9se9eQjgG4WdoCXW3maCnvVcXC6zOgiFOwZ uq1nGkkFmxC4PtXZb2ge0LDj8mndpPE0aeYVv0YdUTEZrLX1/2jIkn0EF/Cc5aVdTL5s R9wg== X-Forwarded-Encrypted: i=1; AJvYcCV8xldPh3lnp2GIV7BvWQjYUlxFjWz0MPfoB0stklNxdK9GyEPf3pXGcb2A89Pf7Z560LOog7j9RZq9o4oaXuXWskYUCg==@freebsd.org X-Gm-Message-State: AOJu0Yw5hExZP3WfTXRUoCDvdy9dRGmSAgUXrK5Dig5XScEF6dl6cMj8 /XwYuM86o50t+edjg8cz4rIRIHbEO7j/AYEtIZt92i4a8xq7fSZ449VQI6N1qiOF+Wahb4yYnYm FsPEIdS9/dzm2OWIbO47nSwNzUuCtbH972fM9Zab63Q== X-Gm-Gg: ATEYQzxMd+h6XJ6kftPfQkcgiKseljcIgHQbXk2sS60orV2QpAofd7UpF9Z0/oOUkyC 8tLfqsEnai0eozAKWgYneF/liGMTOJwe/x+7/C8MY8aP1RROuZcRxG8sVl+AV1h1mY4rRb3RATE DWFxZsFVmS3yzO+Oh/yaAqrYaUiCEXrQFhgw8yO60/V3SF52LtFCtYuF/LcjZKitCuDu8iBIcKb WvF/U0WBzKaX1IyICnYi0QCQ7avOazVhjAMTtXekApaf0aOQ4q3v/2V90ObaBod5WRszI1jaWAT Xh8/zUQdOFj6qg7LrRcaRqWWBczau1ZqilQyMg== X-Received: by 2002:a17:90b:584e:b0:354:a332:1a61 with SMTP id 98e67ed59e1d1-35965c276bfmr11147086a91.5.1772537159971; Tue, 03 Mar 2026 03:25:59 -0800 (PST) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 References: <69a678f3.3f811.148b0d7d@gitrepo.freebsd.org> In-Reply-To: <69a678f3.3f811.148b0d7d@gitrepo.freebsd.org> From: Warner Losh Date: Tue, 3 Mar 2026 04:25:48 -0700 X-Gm-Features: AaiRm52os4sKYYoCYfrNMZLFWv4GlwJt7I8GRJlav4CG_cIpu9ZUBudXuY_8p8w Message-ID: Subject: Re: git: 912864912b71 - main - Run `make obj` before running `make test-includes` To: Enji Cooper Cc: src-committers , "" , "" Content-Type: multipart/alternative; boundary="000000000000c57f16064c1cf72e" X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Queue-Id: 4fQD571HhHz3VCk X-Spamd-Bar: ---- --000000000000c57f16064c1cf72e Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Mar 2, 2026, 11:00=E2=80=AFPM Enji Cooper wrote: > The branch main has been updated by ngie: > > URL: > https://cgit.FreeBSD.org/src/commit/?id=3D912864912b71951f9a636190b1dba80= 528f588eb > > commit 912864912b71951f9a636190b1dba80528f588eb > Author: Enji Cooper > AuthorDate: 2026-03-03 05:59:50 +0000 > Commit: Enji Cooper > CommitDate: 2026-03-03 05:59:56 +0000 > > Run `make obj` before running `make test-includes` > > Before this change, `make test-includes` (run as part of buildworld) > would place test files in the current directory, which would clutter = up > git clones. Run `make obj` beforehand to ensure that the files are pu= t > in `${.OBJDIR}` instead of `${.CURDIR}`. This helps cut down on the > noise significantly when running commands like `git status`. > I've never seen this happen. .OBJDIR is created automatically for me always for the last 5 years... I run buildworld all the time. Can you explain when / how it happens more specifically or back out the change? Warner MFC after: 1 week > Differential Revision: https://reviews.freebsd.org/D55499 > --- > Makefile.inc1 | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Makefile.inc1 b/Makefile.inc1 > index 93c54e0a0d14..c4696abae8cd 100644 > --- a/Makefile.inc1 > +++ b/Makefile.inc1 > @@ -1207,7 +1207,7 @@ _includes: > .if !empty(SUBDIR_OVERRIDE) && make(buildworld) > ${_+_}cd ${.CURDIR}; ${WMAKE} MK_INCLUDES=3Dyes SHARED=3Dsymlinks > includes > .endif > - ${_+_}cd ${.CURDIR}; ${WMAKE} test-includes > + ${_+_}cd ${.CURDIR}; ${WMAKE} test-includes > _libraries: > @echo > @echo > "--------------------------------------------------------------" > @@ -1575,6 +1575,7 @@ makeman: .PHONY > # Ensure no regressions in self-includeability of sys/*.h and net*/*.h > test-includes: .PHONY > ${_+_}cd ${.CURDIR}/tools/build/test-includes; \ > + ${WMAKEENV} ${MAKE} ${WORLD_FLAGS} obj; \ > ${WMAKEENV} ${MAKE} ${WORLD_FLAGS} DESTDIR=3D${WORLDTMP} > test-includes > > # We can't assume here that ${TMPPATH} will include ${PATH} or > /usr/libexec > > --000000000000c57f16064c1cf72e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Mon, Mar 2, 2026, 11:00=E2=80= =AFPM Enji Cooper <ngie@freebsd.org<= /a>> wrote:
The branch main has = been updated by ngie:

URL: ht= tps://cgit.FreeBSD.org/src/commit/?id=3D912864912b71951f9a636190b1dba80528f= 588eb

commit 912864912b71951f9a636190b1dba80528f588eb
Author:=C2=A0 =C2=A0 =C2=A0Enji Cooper <ngie@FreeBSD.org>
AuthorDate: 2026-03-03 05:59:50 +0000
Commit:=C2=A0 =C2=A0 =C2=A0Enji Cooper <ngie@FreeBSD.org>
CommitDate: 2026-03-03 05:59:56 +0000

=C2=A0 =C2=A0 Run `make obj` before running `make test-includes`

=C2=A0 =C2=A0 Before this change, `make test-includes` (run as part of buil= dworld)
=C2=A0 =C2=A0 would place test files in the current directory, which would = clutter up
=C2=A0 =C2=A0 git clones. Run `make obj` beforehand to ensure that the file= s are put
=C2=A0 =C2=A0 in `${.OBJDIR}` instead of `${.CURDIR}`. This helps cut down = on the
=C2=A0 =C2=A0 noise significantly when running commands like `git status`.<= br>

I= 've never seen this happen. .OBJDIR is created automatically for me alw= ays for the last 5 years... I run buildworld all the time. Can you explain = when /=C2=A0 how it happens more specifically or back out the change?
=

Warner

=C2=A0 =C2=A0 MFC after:=C2=A0 =C2=A0 =C2=A0 1 week
=C2=A0 =C2=A0 Differential Revision: https://reviews.fr= eebsd.org/D55499
---
=C2=A0Makefile.inc1 | 3 ++-
=C2=A01 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/Makefile.inc1 b/Makefile.inc1
index 93c54e0a0d14..c4696abae8cd 100644
--- a/Makefile.inc1
+++ b/Makefile.inc1
@@ -1207,7 +1207,7 @@ _includes:
=C2=A0.if !empty(SUBDIR_OVERRIDE) && make(buildworld)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 ${_+_}cd ${.CURDIR}; ${WMAKE} MK_INCLUDES=3Dyes= SHARED=3Dsymlinks includes
=C2=A0.endif
-=C2=A0 =C2=A0 =C2=A0 =C2=A0${_+_}cd ${.CURDIR};=C2=A0 ${WMAKE} test-includ= es
+=C2=A0 =C2=A0 =C2=A0 =C2=A0${_+_}cd ${.CURDIR}; ${WMAKE} test-includes
=C2=A0_libraries:
=C2=A0 =C2=A0 =C2=A0 =C2=A0 @echo
=C2=A0 =C2=A0 =C2=A0 =C2=A0 @echo "-----------------------------------= ---------------------------"
@@ -1575,6 +1575,7 @@ makeman: .PHONY
=C2=A0# Ensure no regressions in self-includeability of sys/*.h and net*/*.= h
=C2=A0test-includes: .PHONY
=C2=A0 =C2=A0 =C2=A0 =C2=A0 ${_+_}cd ${.CURDIR}/tools/build/test-includes; = \
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0${WMAKEENV} ${MAKE} ${WORLD_FLAGS= } obj; \
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ${WMAKEENV} ${MAKE} ${WORLD_FLAGS= } DESTDIR=3D${WORLDTMP} test-includes

=C2=A0# We can't assume here that ${TMPPATH} will include ${PATH} or /u= sr/libexec

--000000000000c57f16064c1cf72e--