From owner-freebsd-bugs@FreeBSD.ORG  Mon May 21 02:40:12 2012
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 1B4EC106564A
	for <freebsd-bugs@hub.freebsd.org>;
	Mon, 21 May 2012 02:40:12 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id BCD578FC12
	for <freebsd-bugs@hub.freebsd.org>;
	Mon, 21 May 2012 02:40:11 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q4L2e3Sb049141
	for <freebsd-bugs@freefall.freebsd.org>; Mon, 21 May 2012 02:40:03 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q4L2e34J049140;
	Mon, 21 May 2012 02:40:03 GMT (envelope-from gnats)
Date: Mon, 21 May 2012 02:40:03 GMT
Message-Id: <201205210240.q4L2e34J049140@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: dfilter@FreeBSD.ORG (dfilter service)
Cc: 
Subject: Re: kern/168095: commit references a PR
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: dfilter service <dfilter@FreeBSD.ORG>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 21 May 2012 02:40:12 -0000

The following reply was made to PR kern/168095; it has been noted by GNATS.

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/168095: commit references a PR
Date: Mon, 21 May 2012 02:30:35 +0000 (UTC)

 Author: kevlo
 Date: Mon May 21 02:30:22 2012
 New Revision: 235711
 URL: http://svn.freebsd.org/changeset/base/235711
 
 Log:
   Fix improper handling of variadic args with ICDEBUG
   
   PR:	kern/168095
   Submitted by:	gcooper
 
 Modified:
   head/sys/libkern/iconv.c
   head/sys/sys/iconv.h
 
 Modified: head/sys/libkern/iconv.c
 ==============================================================================
 --- head/sys/libkern/iconv.c	Mon May 21 02:23:20 2012	(r235710)
 +++ head/sys/libkern/iconv.c	Mon May 21 02:30:22 2012	(r235711)
 @@ -549,9 +549,7 @@ int
  iconv_lookupcp(char **cpp, const char *s)
  {
  	if (cpp == NULL) {
 -		ICDEBUG("warning a NULL list passed\n", ""); /* XXX ISO variadic								macros cannot
 -								leave out the
 -								variadic args */
 +		ICDEBUG("warning a NULL list passed\n", "");
  		return ENOENT;
  	}
  	for (; *cpp; cpp++)
 
 Modified: head/sys/sys/iconv.h
 ==============================================================================
 --- head/sys/sys/iconv.h	Mon May 21 02:23:20 2012	(r235710)
 +++ head/sys/sys/iconv.h	Mon May 21 02:30:22 2012	(r235711)
 @@ -240,7 +240,7 @@ int iconv_converter_tolowerstub(int c, v
  int iconv_converter_handler(module_t mod, int type, void *data);
  
  #ifdef ICONV_DEBUG
 -#define ICDEBUG(format, ...) printf("%s: "format, __func__ , __VA_ARGS__)
 +#define ICDEBUG(format, ...) printf("%s: "format, __func__ , ## __VA_ARGS__)
  #else
  #define ICDEBUG(format, ...)
  #endif
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"