From owner-svn-ports-all@freebsd.org  Thu Jun 30 09:59:28 2016
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 53485B872EA;
 Thu, 30 Jun 2016 09:59:28 +0000 (UTC) (envelope-from mat@FreeBSD.org)
Received: from repo.freebsd.org (repo.freebsd.org
 [IPv6:2610:1c1:1:6068::e6a:0])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 1CE882AF9;
 Thu, 30 Jun 2016 09:59:28 +0000 (UTC) (envelope-from mat@FreeBSD.org)
Received: from repo.freebsd.org ([127.0.1.37])
 by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id u5U9xRFK080026;
 Thu, 30 Jun 2016 09:59:27 GMT (envelope-from mat@FreeBSD.org)
Received: (from mat@localhost)
 by repo.freebsd.org (8.15.2/8.15.2/Submit) id u5U9xRJI080025;
 Thu, 30 Jun 2016 09:59:27 GMT (envelope-from mat@FreeBSD.org)
Message-Id: <201606300959.u5U9xRJI080025@repo.freebsd.org>
X-Authentication-Warning: repo.freebsd.org: mat set sender to mat@FreeBSD.org
 using -f
From: Mathieu Arnold <mat@FreeBSD.org>
Date: Thu, 30 Jun 2016 09:59:27 +0000 (UTC)
To: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: svn commit: r417821 - head/Mk/Scripts
X-SVN-Group: ports-head
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 30 Jun 2016 09:59:28 -0000

Author: mat
Date: Thu Jun 30 09:59:27 2016
New Revision: 417821
URL: https://svnweb.freebsd.org/changeset/ports/417821

Log:
  Only warn about symlinks that exist in the stage directory, or that
  exist nowhere.
  
  Sponsored by:	Absolight

Modified:
  head/Mk/Scripts/qa.sh   (contents, props changed)

Modified: head/Mk/Scripts/qa.sh
==============================================================================
--- head/Mk/Scripts/qa.sh	Thu Jun 30 09:55:18 2016	(r417820)
+++ head/Mk/Scripts/qa.sh	Thu Jun 30 09:59:27 2016	(r417821)
@@ -144,7 +144,14 @@ symlinks() {
 				rc=1
 				;;
 			/*)
-				warn "Bad symlink '${l#${STAGEDIR}}' pointing to an absolute pathname '${link}'"
+				# Only warn for symlinks within the package.
+				if [ -e "${STAGEDIR}${link}" ]; then
+					warn "Bad symlink '${l#${STAGEDIR}}' pointing to an absolute pathname '${link}'"
+				fi
+				# Also warn if the symlink exists nowhere.
+				if [ ! -e "${STAGEDIR}${link}" -a ! -e "${link}" ]; then
+					warn "Symlink '${l#${STAGEDIR}}' pointing to '${link}' which does not exist in the stage directory or in localbase"
+				fi
 				;;
 		esac
 	# Use heredoc to avoid losing rc from find|while subshell.