Date: Sun, 7 Oct 2012 12:44:02 -0600 From: "Justin T. Gibbs" <gibbs@scsiguy.com> To: Andriy Gapon <avg@FreeBSD.org> Cc: Konstantin Belousov <kib@FreeBSD.org>, Pawel Jakub Dawidek <pjd@FreeBSD.org>, fs@FreeBSD.org Subject: Re: ZFS: Deadlock during vnode recycling Message-ID: <97D56E7F-1284-4FB1-8C83-9EE04FE4F59F@scsiguy.com> In-Reply-To: <5071A071.1020800@FreeBSD.org> References: <76CBA055-021F-458D-8978-E9A973D9B783@scsiguy.com> <506EB43B.8050204@FreeBSD.org> <5071A071.1020800@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Oct 7, 2012, at 9:32 AM, Andriy Gapon <avg@FreeBSD.org> wrote: > In fact here is a real patch that I would like to propose: > http://people.freebsd.org/~avg/zfs-getnewvnode_reserve.diff OS-X has these same types of problems and I talked with Don Brady of the OS-X ZFS port about them during ZFS day. It sounds like he explicitly pre-allocates vnodes in these code paths instead of relying on a reserve pool. I plan to review his work since I expect he's found and fixed problems we don't even know we have yet. My only complaint with this patch is that it doesn't include stats counters for these rare conditions so that I can validate that the code is exercised during a test suite. Can you merge in the kstat portion of the change I proposed? -- Justin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?97D56E7F-1284-4FB1-8C83-9EE04FE4F59F>