From owner-freebsd-pf@FreeBSD.ORG Thu Sep 16 04:07:09 2004 Return-Path: Delivered-To: freebsd-pf@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 674) id BE7E516A4CF; Thu, 16 Sep 2004 04:07:09 +0000 (GMT) Delivered-To: mlaier@vampire.homelinux.org Received: (qmail 20671 invoked by alias); 21 Jun 2004 23:46:06 -0000 Delivered-To: max@vampire.homelinux.org Received: (qmail 20668 invoked from network); 21 Jun 2004 23:46:06 -0000 Received: from moutng.kundenserver.de (212.227.126.189) by p548087a5.dip.t-dialin.net with SMTP; 21 Jun 2004 23:46:06 -0000 Received: from [212.227.126.213] (helo=mxng17.kundenserver.de) by moutng.kundenserver.de with esmtp (Exim 3.35 #1) id 1BcYUJ-0006Nk-00 for max@vampire.homelinux.org; Tue, 22 Jun 2004 01:46:07 +0200 Received: from [206.53.239.180] (helo=turing.freelists.org) by mxng17.kundenserver.de with esmtp (Exim 3.35 #1) id 1BcYUI-0007vZ-00 for max@love2party.net; Tue, 22 Jun 2004 01:46:06 +0200 Received: from localhost (localhost [127.0.0.1])ESMTP id AA6D772C462; Mon, 21 Jun 2004 18:24:46 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 25454-95; Mon, 21 Jun 2004 18:24:46 -0500 (EST) Received: from turing (localhost [127.0.0.1])ESMTP id 16C8472C550; Mon, 21 Jun 2004 18:24:46 -0500 (EST) Received: with ECARTIS (v1.0.0; list pf4freebsd); Mon, 21 Jun 2004 18:24:30 -0500 (EST) X-Original-To: pf4freebsd@freelists.org Delivered-To: pf4freebsd@freelists.org Received: from localhost (localhost [127.0.0.1])ESMTP id 7111972C462 for ; Mon, 21 Jun 2004 18:24:30 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 25508-88 for ; Mon, 21 Jun 2004 18:24:30 -0500 (EST) Received: from moutng.kundenserver.de (moutng.kundenserver.de [212.227.126.186])ESMTP id D44D172C51A for ; Mon, 21 Jun 2004 18:24:29 -0500 (EST) Received: from [212.227.126.179] (helo=mrelayng.kundenserver.de) by moutng.kundenserver.de with esmtp (Exim 3.35 #1) id 1BcYTz-0000BJ-00 for pf4freebsd@freelists.org; Tue, 22 Jun 2004 01:45:47 +0200 Received: from [84.128.135.165] (helo=donor.laier.local) by mrelayng.kundenserver.de with asmtp (TLSv1:RC4-MD5:128) (Exim 3.35 #1) id 1BcYTz-0005Sm-00 for pf4freebsd@freelists.org; Tue, 22 Jun 2004 01:45:48 +0200 From: Max Laier To: pf4freebsd@freelists.org User-Agent: KMail/1.6.2 References: <40D760E5.7000903@nipsi.de> In-Reply-To: <40D760E5.7000903@nipsi.de> MIME-Version: 1.0 Content-Type: multipart/signed; protocol="application/pgp-signature"; micalg=pgp-sha1; boundary="Boundary-02=_JK31Ap8gWGBAVmC"; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200406220143.05302.max@love2party.net> X-Provags-ID: kundenserver.de abuse@kundenserver.de auth:e28873fbe4dbe612ce62ab869898ff08 X-Virus-Scanned: by amavisd-new at freelists.org X-archive-position: 344 X-ecartis-version: Ecartis v1.0.0 Sender: pf4freebsd-bounce@freelists.org Errors-To: pf4freebsd-bounce@freelists.org X-original-sender: max@love2party.net Precedence: normal X-list: pf4freebsd X-Virus-Scanned: by amavisd-new at freelists.org X-Provags-Forward: max@love2party.net -> max@vampire.homelinux.org X-UID: 460 X-Length: 5753 X-Mailman-Approved-At: Thu, 16 Sep 2004 04:12:49 +0000 Subject: [pf4freebsd] Re: if_fxp.c.patch X-BeenThere: freebsd-pf@freebsd.org X-Mailman-Version: 2.1.1 Reply-To: pf4freebsd@freelists.org List-Id: Technical discussion and general questions about packet filter (pf) List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Date: Thu, 16 Sep 2004 04:07:09 -0000 X-Original-Date: Tue, 22 Jun 2004 01:42:55 +0200 X-List-Received-Date: Thu, 16 Sep 2004 04:07:09 -0000 --Boundary-02=_JK31Ap8gWGBAVmC Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Tuesday 22 June 2004 00:27, Dennis Berger wrote: > Hi, > today I tried the fxp driver patch and run into a kernelpanic if altq is > enabled. > I guess it's something strange with the locking cause the debugger stops = at > fxp_start_body(); > this is exactly the point where a lock is needed, or whatever there > happens... > > pyun discovered similar problems months ago, he fixed it by modifying > the LOCK macro. > to something like this > > #define MY_LOCK do { \ > if(!mtx_owned(&lock) \ > mtx_lock(&lock); \ > } while(0) > and > #define MY_UNLOCK do { \ > if(mtx_owned(&lock)); \ > mtx_unlock(&lock); \ > } while(0) > > I don't know why he have to check if the lock is held... Neither do I, but maybe you can provide a complete trace of this panic so w= e=20 can find the real problem instead of fixing the symptoms? Moreover, if ther= e=20 is a panic *in* fxp_start_body that means that we fail the mtx_assert (i.e.= =20 the lock was not properly acquired), above fix will not help it. Please provide the complete (function names are enough for a start) trace f= rom=20 that panic in order to give me an idea of the panic. Please also tell me wh= at=20 kind of queues you have set up. Thanks. =2D-=20 Best regards, | mlaier@freebsd.org Max Laier | ICQ #67774661 http://pf4freebsd.love2party.net/ | mlaier@EFnet --Boundary-02=_JK31Ap8gWGBAVmC Content-Type: application/pgp-signature Content-Description: signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQBA13KJXyyEoT62BG0RAlmIAJ4y+uNPTt++VEgtvqJsSBwL0D1doACdF/Za 7QZu2TU034t2PI5xjjvGfv8= =3hmr -----END PGP SIGNATURE----- --Boundary-02=_JK31Ap8gWGBAVmC--