Date: Fri, 14 Jul 2017 20:05:05 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 220737] bsd.java.mk: Strict JAVA_{VERSION,VENDOR,ERROR} validation Message-ID: <bug-220737-13@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D220737 Bug ID: 220737 Summary: bsd.java.mk: Strict JAVA_{VERSION,VENDOR,ERROR} validation Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: Ports Framework Assignee: portmgr@FreeBSD.org Reporter: kevans@freebsd.org CC: freebsd-ports-bugs@FreeBSD.org Flags: exp-run? Created attachment 184363 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D184363&action= =3Dedit svn(1) diff of Mk/bsd.java.mk Noticed while working in the regex around here: validation of JAVA_{VERSION,VENDOR,ERROR} does not constitute an error and make(1) will happily continue, potentially doing the wrong thing. Attached patch adjusts= it as follows: * Only validate each var if it's defined * Also echo "not a valid value" message if the checked var is empty * Fail the build if validation fails --=20 You are receiving this mail because: You are on the CC list for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-220737-13>