From owner-p4-projects@FreeBSD.ORG  Wed Mar 14 20:57:01 2007
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 8FC7316A407; Wed, 14 Mar 2007 20:57:01 +0000 (UTC)
X-Original-To: perforce@FreeBSD.org
Delivered-To: perforce@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 52F6416A401
	for <perforce@FreeBSD.org>; Wed, 14 Mar 2007 20:57:01 +0000 (UTC)
	(envelope-from gonzo@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41])
	by mx1.freebsd.org (Postfix) with ESMTP id 4049A13C458
	for <perforce@FreeBSD.org>; Wed, 14 Mar 2007 20:57:01 +0000 (UTC)
	(envelope-from gonzo@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l2EKv1wl038532
	for <perforce@FreeBSD.org>; Wed, 14 Mar 2007 20:57:01 GMT
	(envelope-from gonzo@FreeBSD.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l2EKv05Y038529
	for perforce@freebsd.org; Wed, 14 Mar 2007 20:57:00 GMT
	(envelope-from gonzo@FreeBSD.org)
Date: Wed, 14 Mar 2007 20:57:00 GMT
Message-Id: <200703142057.l2EKv05Y038529@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	gonzo@FreeBSD.org using -f
From: Oleksandr Tymoshenko <gonzo@FreeBSD.org>
To: Perforce Change Reviews <perforce@FreeBSD.org>
Cc: 
Subject: PERFORCE change 115881 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 14 Mar 2007 20:57:01 -0000

http://perforce.freebsd.org/chv.cgi?CH=115881

Change 115881 by gonzo@gonzo_jeeves on 2007/03/14 20:56:39

	o vm_fault_prefault calls pmap_enter with corespondent entry
	    protection, so if we're prefaulting R/W region with COW 
	    all pages except faulting one are mapped with R/W permissions i
	    and therefore fail to perform COW operation. This issue is to
	    be investigated, meanwhile work it around with disabling prefault
	    for MIPS at all.
	o Some spellchecking stuff.	    

Affected files ...

.. //depot/projects/mips2/src/sys/mips/mips/pmap.c#21 edit

Differences ...

==== //depot/projects/mips2/src/sys/mips/mips/pmap.c#21 (text+ko) ====

@@ -1657,18 +1657,17 @@
 /*
  *	pmap_is_prefaultable:
  *
- *	Return whether or not the specified virtual address is elgible
+ *	Return whether or not the specified virtual address is eligible
  *	for prefault.
  */
 boolean_t
 pmap_is_prefaultable(pmap_t pmap, vm_offset_t va)
 {
-	pt_entry_t *pte;
-
-	pte = pmap_pte(pmap, va);
-	if (pte_valid(pte))
-		return (FALSE);
-	return (TRUE);
+	/* 
+	 * XXX: prefault causes bugs with COW, so let's stick
+	 * with all pages not eligible to prefault.
+	 */
+	return (FALSE);
 }
 
 /*