From owner-freebsd-current Fri Jan 29 08:09:22 1999 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id IAA02723 for freebsd-current-outgoing; Fri, 29 Jan 1999 08:09:22 -0800 (PST) (envelope-from owner-freebsd-current@FreeBSD.ORG) Received: from fgw.netvalue.fr (fgw.netvalue.fr [194.2.38.194]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id IAA02709 for ; Fri, 29 Jan 1999 08:09:18 -0800 (PST) (envelope-from erwan@netvalue.fr) Received: by fgw.netvalue.fr; id RAA29950; Fri, 29 Jan 1999 17:20:58 +0100 (CET) Received: from etoile.netvalue.fr(192.168.1.11) by fgw.netvalue.fr via smap (3.0) id xma029938; Fri, 29 Jan 99 17:20:46 +0100 Received: from netvalue.fr ([192.168.1.100]) by etoile.netvalue.fr (Netscape Messaging Server 3.5) with ESMTP id AAA59F4; Fri, 29 Jan 1999 17:08:19 +0100 Message-ID: <36B1DCB9.8FB42BA4@netvalue.fr> Date: Fri, 29 Jan 1999 17:07:22 +0100 From: Erwan Arzur Organization: NetValue S.A. X-Mailer: Mozilla 4.5 [en] (X11; I; FreeBSD 4.0-CURRENT i386) X-Accept-Language: en MIME-Version: 1.0 To: obrien@NUXI.com CC: Mike Smith , Ustimenko Semen , freebsd-current@FreeBSD.ORG Subject: Re: About to commit NTFS driver References: <199901290050.QAA01195@dingo.cdrom.com> <19990128235511.A24267@relay.nuxi.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG David O'Brien wrote: > > > Driver is readonly, specialy developed for freebsd, > > > supports most of NTFS's features. > > > Source is at http://iclub.nsu.ru/~semen/ntfs/ > > > > Sounds like a good idea. Do you have a reviewer? > > I'm looking at it now for 4.0-C. I'm quite sure it has already been corrected right now, but when building against a fresh 4.0-current as of this morning, you have to change the calls to getpbuf and relpbuf in ntfs_vnops.c ... *** ntfs_vnops.c Thu Jan 28 04:56:06 1999 --- /sys/ntfs/ntfs_vnops.c Fri Jan 29 16:31:16 1999 *************** *** 126,132 **** * We use only the kva address for the buffer, but this is extremely * convienient and fast. */ ! bp = getpbuf(); npages = btoc(count); kva = (vm_offset_t) bp->b_data; --- 126,132 ---- * We use only the kva address for the buffer, but this is extremely * convienient and fast. */ ! bp = getpbuf(NULL); npages = btoc(count); kva = (vm_offset_t) bp->b_data; *************** *** 145,151 **** error = VOP_READ(vp, &uio, 0, cred); pmap_qremove(kva, npages); ! relpbuf(bp); if (error && (uio.uio_resid == count)) return VM_PAGER_ERROR; --- 145,151 ---- error = VOP_READ(vp, &uio, 0, cred); pmap_qremove(kva, npages); ! relpbuf(bp,NULL); if (error && (uio.uio_resid == count)) return VM_PAGER_ERROR; This allows the module to compile and it also runs well : /dev/wd0s6 on /ntfs/disk_f (local) /dev/wd0s7 on /ntfs/disk_g (local) Considering the comments in vm_page.c where these functions are defined, this may need some investigation (can't do this by myself, i get confused with everything that starts with "vm", especially on FreeBSD :-)) To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message