From nobody Thu Jul 23 10:00:57 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4h5RTQ72ZXz6lW0B for ; Thu, 23 Jul 2026 10:00:58 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4h5RTQ0Lz9z3WVF for ; Thu, 23 Jul 2026 10:00:58 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1784800858; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=yZrkYJZ0Qh+Sqxdo/zHBlBcWjE7uesah7rjFROj7z9w=; b=k5XfaS9dfu0UXboG5ZA1trwQqfwuI3YdUxL+oYm1MX8YTekSaeFKLr9/fGxfX92WRQ4bqO 3m6kZsWufhBg++42tK3n+hcCYfWBdQ8HZrBpHttUu2KRxvsicRiwelodQ/gN5ad83pkv44 eLfU8foUrqj1YxM8Me2LVDpKBl0uS9VaRg+Ink2hVzJIiOMR8Ctcg7Ex1ZhxoQ/t5R6ayh fLgPduqKMh3rotUuZeVd2LrnR8zSXT9U07cIw9rWXEIxYdmLCJvUb0ln7qU41Gc9dwur+n +dpWTqqC3zZ+GmejCstnHlWBGJ7mVBVbYhKMk/txVaKKyGY4rB73y8YRstu7pQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1784800858; a=rsa-sha256; cv=none; b=g/Eg+t4hA1I495oldsX0404MEvnbNnp5pZxIDwRHnk/+01o4R7YCTd+7MGQzcgJ627PzBU VJQ6Y3Niuuk9C8q/xAZyw2nQ9vxu8xMRv3oVSA57rKZM1cwg6lp1kts1mAaAHu5X5zl66Q nMm5u5SGyuZzEfJ7I5oP+HPCvzGkY6jLuV4cAIBf1jdPoZRbjJQEwAn3jcKcrgqrNBdJmE 5vCRKS2OQh1b5XConAgxXVvtD+SebNoqzlaDJ7MZO/lEA2QcXQcCuXwKJKW41ib/v5yTA6 EY2Uh8BXx4kC/oivuqKRli9M5Xd3YyQ4C9w0L0Au1JMFkyJPKFgGJWf4PI4u0A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1784800858; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=yZrkYJZ0Qh+Sqxdo/zHBlBcWjE7uesah7rjFROj7z9w=; b=jjQfeT3m7xHjHMpex+KI2htW3SlLr5RlhImu9TeGpPuyy8k1IYYIUeX2eIcUbLNuxLwS88 Gn9g8In/fr1QFQxjSwbs3yCCkmA1I0t1VExdUM7a01EYyqDk40o1+5pQn7EGhqKfgeQFl4 +h8zlTp2xelc0LW/cu1Lj9QUYJ8Qpwa+D4iNbbfbswmYuSp3Oit+wfFbW84Spv5u2Rukd9 7KHbIQ8+Z5ZMw1Xw3BQVTHLkD5fKt0Ci8dvS9uzY8vOCHY8kH89iZWJlSzTpFLtNRuEq1v 8g3CiesXjNz2U7AMTMHceTQhE1aoqmPl4zrg9TDH5SexnH+3kLuwHBYypmHvBA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4h5RTP6H5Bz10xk for ; Thu, 23 Jul 2026 10:00:57 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3bfc9 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 23 Jul 2026 10:00:57 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Olivier Certner Subject: git: 5850343763cb - stable/14 - MAC/do: Clarify comments about flags attached per-ID or per-ID-type List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: olce X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 5850343763cb82096609ac9bd449dd4c3f259ce3 Auto-Submitted: auto-generated Date: Thu, 23 Jul 2026 10:00:57 +0000 Message-Id: <6a61e659.3bfc9.7a56cb5@gitrepo.freebsd.org> The branch stable/14 has been updated by olce: URL: https://cgit.FreeBSD.org/src/commit/?id=5850343763cb82096609ac9bd449dd4c3f259ce3 commit 5850343763cb82096609ac9bd449dd4c3f259ce3 Author: Olivier Certner AuthorDate: 2026-06-04 10:01:23 +0000 Commit: Olivier Certner CommitDate: 2026-07-23 09:59:10 +0000 MAC/do: Clarify comments about flags attached per-ID or per-ID-type No functional change. MFC after: 3 days Sponsored by: The FreeBSD Foundation (cherry picked from commit 0c2d64ce3da9c042da133c8b6d7391abb177f2c9) --- sys/security/mac_do/mac_do.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/sys/security/mac_do/mac_do.c b/sys/security/mac_do/mac_do.c index 338170a0319b..f3d7eb36d064 100644 --- a/sys/security/mac_do/mac_do.c +++ b/sys/security/mac_do/mac_do.c @@ -90,20 +90,22 @@ _Static_assert(sizeof(uid_t) == sizeof(u_int) && (uid_t)-1 >= 0 && * encoding for simplicity. * * There is currently room for "only" 16 bits. As these flags are purely - * internal, they can be renumbered and/or their type changed as needed. + * internal, they can be renumbered and/or the underlying type changed as + * needed. * * See also the check_*() functions below. */ typedef uint16_t flags_t; -/* (i,gid) Specification concerns primary groups. */ +/* (i,gid) Group can appear as a primary group. */ #define MDF_PRIMARY (1u << 0) -/* (i,gid) Specification concerns supplementary groups. */ +/* (i,gid) Group can appear as a supplementary group. */ #define MDF_SUPP_ALLOW (1u << 1) /* (i,gid) Group must appear as a supplementary group. */ #define MDF_SUPP_MUST (1u << 2) /* (i,gid) Group must not appear as a supplementary group. */ #define MDF_SUPP_DONT (1u << 3) +/* (i,gid) Mask to detect a supplementary group specification. */ #define MDF_SUPP_MASK (MDF_SUPP_ALLOW | MDF_SUPP_MUST | MDF_SUPP_DONT) #define MDF_ID_MASK (MDF_PRIMARY | MDF_SUPP_MASK) @@ -111,8 +113,8 @@ typedef uint16_t flags_t; * (t) All IDs allowed. * * For GIDs, MDF_ANY only concerns primary groups. The MDF_PRIMARY and - * MDF_SUPP_* flags never apply to MDF_ANY, but can be present if MDF_CURRENT is - * present also, as usual. + * MDF_SUPP_* flags do not apply to MDF_ANY, but can be present if MDF_CURRENT + * is present also, as for explicit IDs. */ #define MDF_ANY (1u << 8) /* (t) Current IDs allowed. */