From owner-cvs-all@FreeBSD.ORG Wed Mar 31 12:58:59 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 19F9E16A4D2 for ; Wed, 31 Mar 2004 12:58:59 -0800 (PST) Received: from mail4.speakeasy.net (mail4.speakeasy.net [216.254.0.204]) by mx1.FreeBSD.org (Postfix) with ESMTP id D029943D1F for ; Wed, 31 Mar 2004 12:58:58 -0800 (PST) (envelope-from jhb@FreeBSD.org) Received: (qmail 28349 invoked from network); 31 Mar 2004 20:58:58 -0000 Received: from dsl027-160-063.atl1.dsl.speakeasy.net (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) encrypted SMTP for ; 31 Mar 2004 20:58:58 -0000 Received: from 10.50.40.205 (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.10/8.12.10) with ESMTP id i2VKsMDV048661; Wed, 31 Mar 2004 15:58:44 -0500 (EST) (envelope-from jhb@FreeBSD.org) From: John Baldwin To: Doug Barton Date: Wed, 31 Mar 2004 15:56:07 -0500 User-Agent: KMail/1.6 References: <200403270926.i2R9QMiP083177@repoman.freebsd.org> In-Reply-To: <200403270926.i2R9QMiP083177@repoman.freebsd.org> MIME-Version: 1.0 Content-Disposition: inline Message-Id: <200403291155.43206.jhb@FreeBSD.org> Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on server.baldwin.cx cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/etc/rc.d mixer X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 Mar 2004 20:58:59 -0000 On Saturday 27 March 2004 04:26 am, Doug Barton wrote: > dougb 2004/03/27 01:26:22 PST > > FreeBSD src repository > > Modified files: > etc/rc.d mixer > Log: > A few small cleanups: > > 1. Add the shutdown keyword so that the script is run at shutdown time, > and the mixer* files are saved. Huh, it seemed to work in my testing w/o this change. Maybe I botched something. > 2. Twiddle whitespace. Style(9) mandates blank lines at the start of functions with no local variables, so that's why I did that. > 3. Remove an unecessary function, and therefore collapse one variable. Only unnecessary if you don't value abstraction. :) Now if you want to ever change the names of the mixer saved files due to a conflict or some such, you have to change it in multiple places rather than just one. I also did post this script for review on @arch before it was committed, btw. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org