From owner-freebsd-numerics@freebsd.org Fri Dec 28 18:21:05 2018 Return-Path: Delivered-To: freebsd-numerics@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C18BF141E24A for ; Fri, 28 Dec 2018 18:21:05 +0000 (UTC) (envelope-from sgk@troutmask.apl.washington.edu) Received: from troutmask.apl.washington.edu (troutmask.apl.washington.edu [128.95.76.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "troutmask", Issuer "troutmask" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 185B394ABC for ; Fri, 28 Dec 2018 18:21:04 +0000 (UTC) (envelope-from sgk@troutmask.apl.washington.edu) Received: from troutmask.apl.washington.edu (localhost [127.0.0.1]) by troutmask.apl.washington.edu (8.15.2/8.15.2) with ESMTPS id wBSIL1GI026051 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Fri, 28 Dec 2018 10:21:01 -0800 (PST) (envelope-from sgk@troutmask.apl.washington.edu) Received: (from sgk@localhost) by troutmask.apl.washington.edu (8.15.2/8.15.2/Submit) id wBSIL1SX026050; Fri, 28 Dec 2018 10:21:01 -0800 (PST) (envelope-from sgk) Date: Fri, 28 Dec 2018 10:21:01 -0800 From: Steve Kargl To: Justin Hibbits Cc: freebsd-numerics@freebsd.org Subject: Re: Expose all math *l functions as aliases for the * functions when long double == double Message-ID: <20181228182101.GA26033@troutmask.apl.washington.edu> Reply-To: sgk@troutmask.apl.washington.edu References: <20181227160937.51cfe9a5@ralga.knownspace> <20181227221523.GA5197@troutmask.apl.washington.edu> <20181228090036.3ce73ee5@ralga.knownspace> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181228090036.3ce73ee5@ralga.knownspace> User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Queue-Id: 185B394ABC X-Spamd-Bar: + Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [1.12 / 15.00]; ARC_NA(0.00)[]; HAS_REPLYTO(0.00)[sgk@troutmask.apl.washington.edu]; NEURAL_HAM_MEDIUM(-0.20)[-0.203,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; NEURAL_SPAM_SHORT(0.89)[0.894,0]; NEURAL_HAM_LONG(-0.45)[-0.452,0]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_LAST(0.00)[]; DMARC_NA(0.00)[washington.edu]; AUTH_NA(1.00)[]; REPLYTO_ADDR_EQ_FROM(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_MED(-0.20)[21.76.95.128.list.dnswl.org : 127.0.11.2]; MX_GOOD(-0.01)[cached: troutmask.apl.washington.edu]; RCPT_COUNT_TWO(0.00)[2]; R_SPF_NA(0.00)[]; FREEMAIL_TO(0.00)[gmail.com]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:73, ipnet:128.95.0.0/16, country:US]; MID_RHS_MATCH_FROM(0.00)[]; IP_SCORE(0.19)[ip: (0.54), ipnet: 128.95.0.0/16(0.28), asn: 73(0.19), country: US(-0.08)] X-BeenThere: freebsd-numerics@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Discussions of high quality implementation of libm functions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Dec 2018 18:21:05 -0000 On Fri, Dec 28, 2018 at 09:00:36AM -0600, Justin Hibbits wrote: > On Thu, 27 Dec 2018 14:15:23 -0800 > Steve Kargl wrote: > > > On Thu, Dec 27, 2018 at 04:09:37PM -0600, Justin Hibbits wrote: > > > When building editors/calligra on powerpc64 it failed with undefined > > > references to erfl and erfcl. Some digging it turns out that these > > > functions aren't being exposed as weak symbols in libm on platforms > > > where long double is 64 bits, because LDBL_MANT_DIG is not defined > > > in the files defining these functions. The attached patch fixes > > > that case. It's only been compile-tested for powerpc64, but should > > > have no negative impact on any other platform. > > > > > > - Justin > > > > Looks OK to me. > > > > Thanks Steve. I figured there would be no issue, but since this is > listed in MAINTAINERS, better to avoid a possibility of post-commit > backlash. > I'm actually surprised that it took 7 years, 9 months to discover the issue with cbrtl() and 4 years, 5 months with erfl(). -- Steve