From owner-cvs-all  Thu Nov 21 15:49:58 2002
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id F361F37B401; Thu, 21 Nov 2002 15:49:55 -0800 (PST)
Received: from bast.unixathome.org (bast.unixathome.org [66.11.174.150])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 3F09543E4A; Thu, 21 Nov 2002 15:49:55 -0800 (PST)
	(envelope-from dan@langille.org)
Received: from wocker (wocker.unixathome.org [192.168.0.99])
	by bast.unixathome.org (Postfix) with ESMTP
	id 8592E3F4B; Thu, 21 Nov 2002 18:49:54 -0500 (EST)
From: "Dan Langille" <dan@langille.org>
To: Mario Sergio Fujikawa Ferreira <lioux@FreeBSD.org>
Date: Thu, 21 Nov 2002 18:49:54 -0500
MIME-Version: 1.0
Subject: Re: cvs commit: ports/multimedia Makefile ports/multimedia/gtksubtitler Makefile distinfo pkg-comment pkg-descr pkg-plist
Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Message-ID: <3DDD2AD2.2851.BFED7E13@localhost>
In-reply-to: <20021121230418.6004.qmail@exxodus.fedaykin.here>
References: <3DDCEE64.31385.BF016B70@localhost>
X-mailer: Pegasus Mail for Windows (v4.02a)
Content-type: text/plain; charset=US-ASCII
Content-transfer-encoding: 7BIT
Content-description: Mail message body
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

On 21 Nov 2002 at 20:03, Mario Sergio Fujikawa Ferreir wrote:

> On Thu, Nov 21, 2002 at 02:31:42PM -0500, Dan Langille wrote:
> > On 21 Nov 2002 at 10:52, Mario Sergio Fujikawa Ferreir wrote:
> > 
> > > lioux       2002/11/21 10:52:53 PST
> > > 
> > >   Modified files:
> > >     multimedia           Makefile 
> > >   Added files:
> > >     multimedia/gtksubtitler Makefile distinfo pkg-comment 
> > >                             pkg-descr pkg-plist 
> 
> [snip]
> 
> > Should we be concerned about this in BUILD_DEPENDS?
> > 
> > [dan@undef:~/ports/multimedia/gtksubtitler] $ export THINGS=`make -V
> > BUILD_DEPENDS` [dan@undef:~/ports/multimedia/gtksubtitler] $ echo
> > "'$THINGS'" '        '
> > 
> > Normally, it is empty:
> > 
> > [dan@undef:~/ports/multimedia/gtksubtitler] $ cd 
> > ../../security/logcheck/
> > [dan@undef:~/ports/security/logcheck] $ export THINGS=`make -V
> > BUILD_DEPENDS` [dan@undef:~/ports/security/logcheck] $ echo
> > "'$THINGS'" ''
> > 
> > Similarly, for RUN_DEPENDS, we have leading and trailing spaces
> > 
> > [dan@undef:~/ports/multimedia/gtksubtitler] $ export THINGS=`make -V
> > RUN_DEPENDS` [dan@undef:~/ports/multimedia/gtksubtitler] $ echo
> > "'$THINGS'" '
> > /usr/X11R6/share/gnome/.keep_me:/usr/ports/misc/gnomehier       '
> 
>  This is mostly weird since the contents of Makefile are
> 
> # New ports collection makefile for:	gtksubtitler
> # Date created:         Thu Nov 21 15:05:53 UTC 2002
> # Whom:			Mario Sergio Fujikawa Ferreira <lioux@FreeBSD.org>
> #
> # $FreeBSD: ports/multimedia/gtksubtitler/Makefile,v 1.1 2002/11/21
> # 18:52:53 lioux Exp $
> #
> 
> PORTNAME=	GTKsubtitler
> PORTVERSION=	0.1.3
> CATEGORIES=	multimedia gnome
> MASTER_SITES=	http://dark.pkn.com.pl/~pawel/gtksubtitler/download/
> DISTNAME=	${PORTNAME}-v${PORTVERSION}
> 
> MAINTAINER=	lioux@FreeBSD.org
> 
> LIB_DEPENDS=	gnugetopt.1:${PORTSDIR}/devel/libgnugetopt
> 
> USE_X_PREFIX=	yes
> USE_GNOMENG=	yes
> USE_GNOME=	gnomeprefix gnomelibs
> USE_REINPLACE=	yes
> GNU_CONFIGURE=	yes
> 
> post-patch:
> # disable GNU auto* tools
>  @${FIND} ${WRKSRC} -type f -name "Makefile.in" | \
>   ${XARGS} -x -n 10 ${REINPLACE_CMD} -E -e \
>   's!^(ACLOCAL|AUTOCONF|AUTOMAKE|AUTOHEADER).+$$!\1=${TRUE}!'
> 
> .include <bsd.port.mk>
> 
>  How could that be broken? Any weird changes to
> ports/Mk/bsd.port.mk ?
> 
>  Regards,

For what it's worth, I found several hundred examples in FreshPorts 
where the RUN_DEPENDS and/or BUILD_DEPENDS contained either multiple 
spaces, trailing spaces, or leading spaces.  I have already fixed 
them all in production.  If it is useful, I can get a full list from 
a backup (but not until Friday, I'm just on my way out).

FYI: I've also fixed the development version of FreshPorts to trim 
leading and trailing whitespace, and reduce multiple spaces to a 
single space.
-- 
Dan Langille : http://www.langille.org/


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message