From owner-svn-src-head@freebsd.org Fri Jul 15 04:54:43 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D8164B9782C; Fri, 15 Jul 2016 04:54:43 +0000 (UTC) (envelope-from cy.schubert@komquats.com) Received: from smtp-out-so.shaw.ca (smtp-out-so.shaw.ca [64.59.136.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 8C3CC1BB0; Fri, 15 Jul 2016 04:54:43 +0000 (UTC) (envelope-from cy.schubert@komquats.com) Received: from spqr.komquats.com ([96.50.22.10]) by shaw.ca with SMTP id Nv8zbK5iA32mrNv90boYwk; Thu, 14 Jul 2016 22:54:36 -0600 X-Authority-Analysis: v=2.2 cv=ROzxJMq+ c=1 sm=1 tr=0 a=jvE2nwUzI0ECrNeyr98KWA==:117 a=jvE2nwUzI0ECrNeyr98KWA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=cAmyUtKerLwA:10 a=6I5d2MoRAAAA:8 a=YxBL1-UpAAAA:8 a=71zuUyp6xY4KTf1MVSQA:9 a=IjZwj45LgO3ly-622nXo:22 a=Ia-lj3WSrqcvXOmTRaiG:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTPS id BC08C13752; Thu, 14 Jul 2016 21:07:31 -0700 (PDT) Received: from slippy (localhost [127.0.0.1]) by slippy.cwsent.com (8.15.2/8.15.2) with ESMTP id u6F4sXK8006100; Thu, 14 Jul 2016 21:54:33 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <201607150454.u6F4sXK8006100@slippy.cwsent.com> X-Mailer: exmh version 2.8.0 04/21/2012 with nmh-1.6 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Cy Schubert cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r302865 - head In-Reply-To: Message from Cy Schubert of "Fri, 15 Jul 2016 04:43:38 -0000." <201607150443.u6F4hcan060828@repo.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Thu, 14 Jul 2016 21:54:33 -0700 X-CMAE-Envelope: MS4wfCbwcFu/jwPBmxgGhxxeVj74ArwS7aG/8X13M8ouAtZ78sbneIiSR1HUWPekuix3PqOnnLEn3eMUPiGo/tQbDkUvP6RNEISFpJdcAwV1UnJreK1cZ0zg vO7vB/qKhH04CbKvWSC99eanqwiXexPA6lWbOOm0KsZkbM+ccIGdA0SCwbRWANrEDQdONH30FMOSNebwqHPWe1nqLWwC5jwDUE7/OrGKpDkMwwMsLvAg3B+A UBoF6FIR43h2/vVqdrjf2SheipYzOKLjg6jUyO5xPspuMeLIFiZdOMRB2uywhhIc X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Jul 2016 04:54:43 -0000 In message <201607150443.u6F4hcan060828@repo.freebsd.org>, Cy Schubert writes: > Author: cy > Date: Fri Jul 15 04:43:38 2016 > New Revision: 302865 > URL: https://svnweb.freebsd.org/changeset/base/302865 > > Log: > When building multiple kernels using KERNCONF, non-existent KERNCONF > files will produce an error and buildkernel will fail. Previously missing > KERNCONF files silently failed giving no indication as to why, only to > subsequently discover during installkernel that the desired kernel was > never built in the first place. > > Reviewed by: ngie@ > MFC after: 1 week > Differential Revision: D7167 > > Modified: > head/Makefile.inc1 > > Modified: head/Makefile.inc1 > ============================================================================= > = > --- head/Makefile.inc1 Fri Jul 15 04:42:08 2016 (r302864) > +++ head/Makefile.inc1 Fri Jul 15 04:43:38 2016 (r302865) > @@ -1140,6 +1140,8 @@ BUILDKERNELS+= ${_kernel} > .if empty(INSTALLKERNEL) && !defined(NO_INSTALLKERNEL) > INSTALLKERNEL= ${_kernel} > .endif > +.else > +.error Missing KERNCONF ${KERNCONFDIR}/${_kernel} > .endif > .endfor > > Ngie@ suggested that this also be a relnotes candidate. I'm not sure if I'd go so far. I'll leave it open for discussion or if re@ wants to. -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.