Date: Fri, 22 Mar 2002 09:06:45 -0500 (EST) From: Andrew Gallatin <gallatin@cs.duke.edu> To: Doug Rabson <dfr@nlsystems.com> Cc: <obrien@FreeBSD.ORG>, Warner Losh <imp@harmony.village.org>, <alpha@FreeBSD.ORG> Subject: Re: Expected compiler error on GENERIC? Message-ID: <15515.14965.734826.531495@grasshopper.cs.duke.edu> In-Reply-To: <20020322084903.F99274-100000@salmon.nlsystems.com> References: <15513.61122.201509.896981@grasshopper.cs.duke.edu> <20020322084903.F99274-100000@salmon.nlsystems.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Doug Rabson writes:
>
> Perhaps badaddr should take a volatile pointer argument?
I think that could cause more trouble than its worth.. This one case
was just an accident of how I laid things out.
I think there is something else wrong with badaddr, though.. We
shouldn't be doing the read if we got a fault. Eg:
Index: interrupt.c
===================================================================
RCS file: /home/ncvs/src/sys/alpha/alpha/interrupt.c,v
retrieving revision 1.64
diff -u -r1.64 interrupt.c
--- interrupt.c 11 Mar 2002 19:58:53 -0000 1.64
+++ interrupt.c 22 Mar 2002 14:04:19 -0000
@@ -300,7 +300,7 @@
/* disallow further machine checks */
mc_expected = 0;
- if (rptr) {
+ if (rptr && mc_received == 0) {
switch (size) {
case sizeof (u_int8_t):
*(volatile u_int8_t *)rptr = rcpt;
Drew
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-alpha" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?15515.14965.734826.531495>