From owner-freebsd-arch  Thu Sep  5 11:48:14 2002
Delivered-To: freebsd-arch@freebsd.org
Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 4300437B400
	for <arch@FreeBSD.ORG>; Thu,  5 Sep 2002 11:48:08 -0700 (PDT)
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 53BDB43E84
	for <arch@FreeBSD.ORG>; Thu,  5 Sep 2002 11:48:04 -0700 (PDT)
	(envelope-from bde@zeta.org.au)
Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102])
	by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id EAA16648;
	Fri, 6 Sep 2002 04:47:44 +1000
Date: Fri, 6 Sep 2002 04:55:11 +1000 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender: bde@gamplex.bde.org
To: "M. Warner Losh" <imp@bsdimp.com>
Cc: arch@FreeBSD.ORG
Subject: Re: Make more things honor NOFSCHG
In-Reply-To: <20020905.112243.88255915.imp@bsdimp.com>
Message-ID: <20020906044316.T8183-100000@gamplex.bde.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-freebsd-arch@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-arch.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-arch>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-arch>
X-Loop: FreeBSD.ORG

On Thu, 5 Sep 2002, M. Warner Losh wrote:

> Right now only libraries will honor NOFSCHG.  Laying aside for the
> moment the whole !@#$!$#@^$#^ NOFOO vs NO_FOO bikeshed, I'd like to
> commit the following patch to make other places where -fschg are added
> to installflags.  This allows one to more things over a mix of local
> file systems and NFS and have them work (right now if you build on a
> local fs, then try to delete it via nfs, it fails because one can't
> unset file flags over nfs).
>
> Comments?
>
> Warner
>
> Index: bin/rcp/Makefile
> ===================================================================
> RCS file: /cache/ncvs/src/bin/rcp/Makefile,v
> retrieving revision 1.20
> diff -u -r1.20 Makefile
> --- bin/rcp/Makefile	18 Apr 2002 07:01:34 -0000	1.20
> +++ bin/rcp/Makefile	5 Sep 2002 17:14:09 -0000
> @@ -23,6 +23,8 @@
>
>  BINOWN=	root
>  BINMODE=4555
> +.if !defined(NOFSCHG)
>  INSTALLFLAGS=-fschg
> +.endif
>
>  .include <bsd.prog.mk>
> ...

Why not use the standard method of zapping install flags (INSTALLFLAGS_EDIT)?
E.g.,

    INSTALLFLAGS_EDIT=':S/-fschg//g'

zaps all instances of -fschg.  See the log message for bsd.prog.mk 1.84
for more examples.

Bruce


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-arch" in the body of the message