From nobody Tue Jun 9 14:09:39 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gZW4g6FrXz6g3PT for ; Tue, 09 Jun 2026 14:09:39 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gZW4g5FkQz3tfw for ; Tue, 09 Jun 2026 14:09:39 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1781014179; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=SHqhG9SMIj3H+cZLNCN4a2jFoU9yIklyBi+r9lH4QnQ=; b=InDjlMNYnJotz5mdBZZ3pSSlauxsFmWB3EV7dk4ettYwGl526naRXiyhVlcO5xV9A5tSJm dZjCwEwbQ4ymoGOT+EJtNrcsI0SZ2QdMYqiP7Bbfs1vunoEZDRobiikwfKgxvOKNb40qn4 bCzovg6IICURe1drWnqss4mCYcocmfeKLtv2SRxDVJ9rpmWWampGWSqPw4ZkvkLKXhz6Ga s7s420LiTdqYDQzBX1j+W1/TsgO1iqmGBUJMKqZ5CqJ3g3+HYjCBGh/nIT6OUBEjl8tru+ Wjm6CIZ+1zDn3ltW+hary//P9QxZ9xBncx50RLjSdc8p6ap3rOaEBPeuYjx4cw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1781014179; a=rsa-sha256; cv=none; b=vAEGHWzsFWYmJFyZN/wyK4i493Slf876X480siA/DGW970iQlaFNbH5y71fcUMeaYGsjKJ b75wpDRYppHKBZvJ6hUuns4h/etvkPYGt33UfG1rFCs34PUEWpeHW7dnL9NLGSP7jZ9gI7 z9A5hNKHNGIL4Maks2CUBmsbsBs8+Xy5WBhVYPr0othvLrLiR2eKBhlmLMCkOXut3+jPT0 HvtcuodxlIhlYP31j3rTzo/aUkO1WTC2ozDk45avwoSnVQvfp0RRi9QypE63D9tAGFpfIf FQQhqhdo5dJRcQETUXheOnFRjBpxQ0z4PDd93b1bhz6CZ/YPv+ujojBq/s7dsg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1781014179; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=SHqhG9SMIj3H+cZLNCN4a2jFoU9yIklyBi+r9lH4QnQ=; b=ouqF9gYUQ91FTKDsmb14UxVbx4/06ee1dbKaF6EL4JULFRhl91Ua7rWNzsX4qJD8apjkRH n2cAX/yE54SsemGVR22ETqQfagMFJ17gh6+u8p6gSFR6Dizx0HLUGKBmJie/hWFvQY6Um7 ILMXlUfX3c9hSiE+b9wYGFyCYevvGk01Tc3PTb3Lh2Vcdj1ci6NOPGBuaZzI8BKpgL5FVb FSdYEwYWfsB4lzLtqOr0nAbOv0UFV8FLhdR8iP13vlQQJjhlS8N17nQbEEyjp/vumNPphk 8NQotjrEdIKJthg7TLvPMdsM1C4LCY7NG8qu5WwKu9kBL+zDwRlSunhxknZeJg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gZW4g4bqwzdyp for ; Tue, 09 Jun 2026 14:09:39 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 45010 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 09 Jun 2026 14:09:39 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Ed Maste Subject: git: 90c11896412d - stable/15 - netlink: Avoid undefined behaviour List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: emaste X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 90c11896412d59c8624c4d05b2f339685fbfd586 Auto-Submitted: auto-generated Date: Tue, 09 Jun 2026 14:09:39 +0000 Message-Id: <6a281ea3.45010.4edf9e2a@gitrepo.freebsd.org> The branch stable/15 has been updated by emaste: URL: https://cgit.FreeBSD.org/src/commit/?id=90c11896412d59c8624c4d05b2f339685fbfd586 commit 90c11896412d59c8624c4d05b2f339685fbfd586 Author: Ed Maste AuthorDate: 2026-05-22 00:50:00 +0000 Commit: Ed Maste CommitDate: 2026-06-09 13:40:28 +0000 netlink: Avoid undefined behaviour Even though it is not dereferenced, it is UB to take the address of an out of bounds array element. Reviewed by: pouria, bz, des, adrian Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D57158 (cherry picked from commit 1a4ad649cb135501f0bee56a4214e8c904ca402e) --- sys/netlink/netlink_generic.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/netlink/netlink_generic.c b/sys/netlink/netlink_generic.c index fb74860e42b3..c2f82eed5656 100644 --- a/sys/netlink/netlink_generic.c +++ b/sys/netlink/netlink_generic.c @@ -127,13 +127,13 @@ genl_handle_message(struct nlmsghdr *hdr, struct nl_pstate *npt) } family_id = hdr->nlmsg_type - GENL_MIN_ID; - gf = &families[family_id]; if (__predict_false(family_id >= MAX_FAMILIES || - gf->family_name == NULL)) { + families[family_id].family_name == NULL)) { NLP_LOG(LOG_DEBUG, nlp, "invalid message type: %d", hdr->nlmsg_type); return (ENOTSUP); } + gf = &families[family_id]; struct genlmsghdr *ghdr = (struct genlmsghdr *)(hdr + 1);