From owner-svn-src-all@FreeBSD.ORG Wed Oct 20 07:44:31 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0558B106566B; Wed, 20 Oct 2010 07:44:31 +0000 (UTC) (envelope-from bschmidt@techwires.net) Received: from mail-bw0-f54.google.com (mail-bw0-f54.google.com [209.85.214.54]) by mx1.freebsd.org (Postfix) with ESMTP id 395B58FC16; Wed, 20 Oct 2010 07:44:29 +0000 (UTC) Received: by bwz15 with SMTP id 15so1036071bwz.13 for ; Wed, 20 Oct 2010 00:44:29 -0700 (PDT) Received: by 10.204.84.216 with SMTP id k24mr6532877bkl.132.1287559237696; Wed, 20 Oct 2010 00:20:37 -0700 (PDT) Received: from jessie.localnet (p5B0E15E3.dip0.t-ipconnect.de [91.14.21.227]) by mx.google.com with ESMTPS id r21sm11129610bkj.22.2010.10.20.00.20.35 (version=SSLv3 cipher=RC4-MD5); Wed, 20 Oct 2010 00:20:36 -0700 (PDT) Sender: Bernhard Schmidt From: Bernhard Schmidt To: "Bjoern A. Zeeb" Date: Wed, 20 Oct 2010 09:20:34 +0200 User-Agent: KMail/1.13.2 (Linux/2.6.32-25-generic; KDE/4.4.2; i686; ; ) References: <201010191911.o9JJBaQe024210@svn.freebsd.org> <20101019220455.D46881@maildrop.int.zabbadoz.net> In-Reply-To: <20101019220455.D46881@maildrop.int.zabbadoz.net> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201010200920.34413.bschmidt@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r214070 - head/sys/dev/if_ndis X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: bschmidt@freebsd.org List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Oct 2010 07:44:31 -0000 On Wednesday, October 20, 2010 00:06:09 Bjoern A. Zeeb wrote: > On Tue, 19 Oct 2010, Bernhard Schmidt wrote: > > Author: bschmidt > > Date: Tue Oct 19 19:11:36 2010 > > New Revision: 214070 > > URL: http://svn.freebsd.org/changeset/base/214070 > > > > Log: > > There is no reason to call rt_ifmsg(), remove it. > > While it's indeed very uncommon to have that in a driver, I don't know > how much black magic if_ndis(4) is. Have you verified that you still > get the events from elsewhere on the routing socket when > loading/unloading if_ndif.ko? I followed the function calls, and the affected ndis_linksts_done() function is only a wrapper around others. Those functions do all call if_link_state_change() which itself calls rt_ifmsg(). It seems the call is just a leftover from the the transition to if_link_state_change(). -- Bernhard