Date: Fri, 10 Feb 2006 17:53:47 +0900 (JST) From: Tod McQuillin <devin@spamcop.net> To: Anton Berezin <tobez@FreeBSD.org> Cc: perl@FreeBSD.org Subject: Re: ports/93122: [PATCH] www/p5-HTML-Parser: [fix build on 4.x] Message-ID: <20060210175230.W64085@plexi.pun-pun.prv> In-Reply-To: <200602100842.k1A8gkKJ065130@freefall.freebsd.org> References: <200602100842.k1A8gkKJ065130@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 10 Feb 2006, Anton Berezin wrote: > Synopsis: [PATCH] www/p5-HTML-Parser: [fix build on 4.x] > > State-Changed-From-To: open->closed > State-Changed-By: tobez > State-Changed-When: Fri Feb 10 09:42:46 CET 2006 > State-Changed-Why: > Whoops, I fixed it independently with a slightly different patch before > seeing your PR. Thanks anyway. I thought about doing it your way but I wasn't sure if accessing ->offset, ->line, ->column would be valid if ->eof was true. But comparing with version 3.48 I see it used to access them without checking so I guess it's okay. It does change the meaning of the code though. -- Tod
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060210175230.W64085>