From owner-svn-ports-all@FreeBSD.ORG  Tue Mar 24 18:37:58 2015
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 9D7B0265;
 Tue, 24 Mar 2015 18:37:58 +0000 (UTC)
Received: from shepard.synsport.net (mail.synsport.com [208.69.230.148])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 707452ED;
 Tue, 24 Mar 2015 18:37:57 +0000 (UTC)
Received: from [192.168.0.22] (unknown [130.255.19.191])
 (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
 (No client certificate requested)
 by shepard.synsport.net (Postfix) with ESMTP id 71868435AC;
 Tue, 24 Mar 2015 13:37:44 -0500 (CDT)
Message-ID: <5511AEF0.4010304@marino.st>
Date: Tue, 24 Mar 2015 19:37:36 +0100
From: John Marino <freebsd.contact@marino.st>
Reply-To: marino@freebsd.org
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
 rv:24.0) Gecko/20100101 Thunderbird/24.5.0
MIME-Version: 1.0
To: John Marino <marino@FreeBSD.org>, ports-committers@freebsd.org, 
 svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject: Re: svn commit: r382100 - in head: archivers/pixz archivers/pixz/files
 dns/dualserver french/aster japanese/scim-skk news/nzbget ports-mgmt/bpm
 sysutils/freeipmi x11-wm/libcompizconfig
References: <201503241351.t2ODpIjS082125@svn.freebsd.org>
 <20150324183132.GD11473@graf.pompo.net>
In-Reply-To: <20150324183132.GD11473@graf.pompo.net>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 24 Mar 2015 18:37:58 -0000

On 3/24/2015 19:31, Thierry Thomas wrote:
>> Modified: head/french/aster/Makefile
>> ==============================================================================
>> --- head/french/aster/Makefile	Tue Mar 24 13:43:16 2015	(r382099)
>> +++ head/french/aster/Makefile	Tue Mar 24 13:51:17 2015	(r382100)
>> @@ -252,9 +252,9 @@ pre-configure:
>>  	${ECHO_CMD} "F90='${FC}'"				>> ${WRKSRC}/setup.cfg
>>  	${ECHO_CMD} "MATHLIB='${lib_math} ${LDFLAGS} -lgfortran -lm -lkvm'"		\
>>  		>> ${WRKSRC}/setup.cfg
>> -	${ECHO_CMD} "OTHERLIB='-Xlinker -export-dynamic -lutil ${PTHREAD_LIBS} -lz'"	\
>> +	${ECHO_CMD} "OTHERLIB='-Xlinker -export-dynamic -lutil -lpthread -lz'"	\
> 
> I agree with you when you remove lines or patches such as
> 
> s/-lpthread/${PTHREAD_LIBS}/
> 
> but I disagree with your changes here: it's better to add
> ${PTHREAD_LIBS} than -lpthread.
> 

The blanket task is to remove ${PTHREAD_LIBS}.  We are going to remove
it from ports entirely.  And it only has one possible value (defined in
bsd.port.mk, so it's safe to replace with either -pthread or -lpthread
(the latter is preferred now).

John