From owner-svn-src-head@freebsd.org Fri May 11 01:27:57 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 97304FAEE4B; Fri, 11 May 2018 01:27:57 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 0DB697D5C8; Fri, 11 May 2018 01:27:56 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1]) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id w4B1Ro2Q073115; Thu, 10 May 2018 18:27:50 -0700 (PDT) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: (from freebsd@localhost) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id w4B1RoUT073114; Thu, 10 May 2018 18:27:50 -0700 (PDT) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201805110127.w4B1RoUT073114@pdx.rh.CN85.dnsmgr.net> Subject: Re: svn commit: r333476 - head/sys/net In-Reply-To: <86po23vvf9.fsf@next.des.no> To: =?UTF-8?Q?Dag-Erling_Sm=C3=B8rgrav?= Date: Thu, 10 May 2018 18:27:50 -0700 (PDT) CC: rgrimes@freebsd.org, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 May 2018 01:27:57 -0000 [ Charset UTF-8 unsupported, converting... ] > "Rodney W. Grimes" writes: > > "Dag-Erling Sm?rgrav" writes: > > > In ifa_maintain_loopback_route(), don't needlessly log an error if we > > > either failed to add a route because it already existed or failed to > > > remove one because it did not. We still return an error code, though. > > Those are the only conditions under which I have ever seen this code > > log anything. These usually occur for me when a tunX device is going > > down, the route gets ripped out long before maintain_loopback ever has > > a chance to remove it. > > I have a few routers with hundreds of dynamically configured vlan > interfaces, so I get a *lot* of these... So do I, and the thing I found best is to just totally rip out the ifa_maintain_loopback code and let bird deal with my routes. I do no need or want these routes created by this mechanism on my FreeBSD based routers, they only ever existed originally to use the MTU of the lo0 interface for things that wrongly open an IP address of an interface rather than 127.0.0.1. -- Rod Grimes rgrimes@freebsd.org