From nobody Thu Feb 16 00:08:46 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PHFfm6M8Cz3rXWT for ; Thu, 16 Feb 2023 00:09:04 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic303-25.consmr.mail.gq1.yahoo.com (sonic303-25.consmr.mail.gq1.yahoo.com [98.137.64.206]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4PHFfl48S4z3yDb for ; Thu, 16 Feb 2023 00:09:03 +0000 (UTC) (envelope-from marklmi@yahoo.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=yahoo.com header.s=s2048 header.b="MRQbGm/U"; spf=pass (mx1.freebsd.org: domain of marklmi@yahoo.com designates 98.137.64.206 as permitted sender) smtp.mailfrom=marklmi@yahoo.com; dmarc=pass (policy=reject) header.from=yahoo.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1676506141; bh=OTw6jWnIRCg76f4iHt4tzlImIwZB7OZpxQ2tnHUILOY=; h=From:Subject:Date:To:References:From:Subject:Reply-To; b=MRQbGm/UgtLjQMMsYEgEPY+Oyv8jsK8vGVshLjJENkYPtDkQJMYocCHLutTBm/L4gjpDrfOwbEiPD6yYTYYbkr7clKTDokKe4b94ROHmEBBPy/txc+lwaBjeUjG3vobyDeUBaCUODC3A+hVTE7wp8AB7t8j6RxKbjVl1JqfaCvHEgQhApu7ggHxtkdQfz8RVAceM1iXc99qnjWapgZMh9lYvhInlFGIrFmNDG7ZdJGI7zEDiu7kGYWyEDlLnpu8o4IKm6+Mn1WRm06oMwVb7EX3ealTZSSi/yT1I0SkY854VZEHyo73YcTBXz/jLVtpkfIAUcVZEnvTcjEVxLHes6Q== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1676506141; bh=OJGmVF8u9JmylKXoJuSe8Jjbpswm4vMxJ2xaYUyp9C2=; h=X-Sonic-MF:From:Subject:Date:To:From:Subject; b=MfoWtikrWOJSpRNJKtQ/TTgovvwCcKPbWwRlAZk/yDFfSEmEIC1NERrhUT2KIg7e9veTKTV5zwOL63qXDQO+/J8vMZNxOfjFYbcFHzlRatpMrPIstap3Em0LNA88YUQ83qHy+zcULpOy/nViMis3l1dFpQYuR+eY9KnL/jtOkciNjTkNrhEOKOKbgd23Nx10bMUuFVBUdS1vONtYEgGScwRr5+6SRRmu8gzSrS69Qtfoqu2dsbYnyJ01Nom6RUIouM6yOZx0RaWZ1ead1UXrDZ9erPGI8M4aTUatOdQJjDzlkDUwC4d/Or1ndLoiWQ15d3lWlmSCADQ6VM6lnLCjpQ== X-YMail-OSG: Y6pxpekVM1mbaAILdBBmIJ.LO.2FgGPcaDdtczRBWDwqsrZI5McPZRYXiJHxptC wGnyPDH95h8dkULIllVnUfGzyqOXmvXEOBjMgA_iT5G_S68tVoxuKpdeG7l2nEAUgdVXpZdsQnmm zZOKFEct6H8D60LzSqJ3x..d6FKgaQ8Su0OBEPxhgDOmbv_1KuQKxugZ36SDeleJld6EkGjn2JEH IN9ZOpOqT3eSztpmvzmueOA92NpCMRzK2PJbfFh1spp719KGtyFFgpspJf3Xr0gXjys3PY2T2uDb sRH3uRsgIDNCjjOKMAp77bCfoNrgcZcp6UZkyY9igOWTJPSlHGaBtIQSVvah1WT.A9GLLV.VqyDx kFMsjuk0WrrMmZdeVMILl5rchDenvRzWVq7kpSSAc9NaISQcVdCjV2JEMFlbp.CJNjkFQbOSCv_L FBMPPF5C2hG4C3aKYS.dxFWQvnqanMAcaH.RUwRpHYY3kKdNfdypNdvT936vV5LFUGE_FqhOtcs5 _cJFm0qfdXwsOREGTLHaOLLh7l5wGrRqUqvoic3BNvvcynIYztB5TmOHU3D6dulZoL_IPrJCgxoW ft59rbUig5X7xDEu6RgJCCOZ.WRLVseUtr29UkNewTeV0lfbjDRz3FzxnZpSf3IILf5f89hoao01 _g6hBsc5JJZDx4TB.3RYpxzYg0GSWkyBi37vGqgHLEVcyD6CMyDuiu_whGTuTqQ_i_d47jFRxZlE zpFqGozbUupRXEeRDmqwfaJ8jAyYMxiDdSyTec0LFTXjFm_v5muuC4i1yqOV1dvnHBu71Ksc7J8u sG.HBbFXeVSBr2nChNKsFdPtjN3iyg8MVuCHUASc1LApu6omjVn.sNSci6eiMAqau6bFoMuv4Unn 0F0OFlT2Qb85wlYGYVz.lwYSBt8lHbz20BjGAPanru0_vTDIjXeonxmU0GMViwa7g6XmOfu95bDL WPlhNDfBE.AGRJFdnvQRi8WwbslZjyJh0q11vowpugdYNx.q5xAep7GwAEE9z8O_aSTDdJZpOFO5 0eTNj8VNjH_3qMLBisYBzPkQBovtBMdurlcRyXdWwN3PFCrXc9xVXe2r08oYwBxWeEneqRXcDfFo a.9AYggw71Tq.lgYY8Vv1CTdSZl3d.RPdte76U9229sN7jvpcAU_YlXduAj_OvUYJL4AipIYooTF AwNrsvaHEyBEV97Y1QE7olZXbPdmV67Fa6_Yg21LYvg45fO44mwlwjQTPNCj1AcsojDXTpYF1MmV Lq9G.WbggWrMEUcG2OT99po2IQfS5ZG3_Che7ixxW2YKbNrVUsqvNj75EGaMMYqQBDeQ.njO8wFn k4b5.b3csjljVLlONuUDS09XtDRFVWUzK8BZqjxs6ZeQdaMc_sighfnhqD.rv2pVOwz.FPuFhu6k 9Fmp0Ilmmxv8JG1tfn3yHKCjr3S_HZeSCR1Rkhk8OxFpK3kuXyJnalsNvipoQLHwsVHdmnyU.TVA sTN4XVE9Vz7rXGEAg2f7NbTUcPDmM_5EPKPAV9TrAo.1MKhhpVqI16fDKtx_41zTtem3ZyFPnkjw _Fz7eo5yvy5j9NPsiJi0jqQMPsa7vlEbMgyY6.JC5FzYQBc6fLE0mvMESvnjWZD03GSUIAQof1Ok giY2bEgPaPLmeV.34yf4bermCXKKDOgKXngz..wiSvJ8sF_8SMGYomti1PVL2VtssdepAv4ZHkvQ RNWVjFE5zRO9._qbJC4HxucbhpI9915YekD3d6dD3YfGp6_rBbtMmMCq5v03gAfWWyajn9DhWazn XzgceTE.3eeoVCNhgVECpT3HRRSI_JbM0Xwwm9uzFfxq6g4UT7GgfBjXRwxj81TTVjv20lgIJg3m kQCC4kDZSQ68ONZ.vtDlNXYlDY2natSBwXDzT1YSWU6RsMbSW0hayt63cfEtpCOyAPDqkzxbFAvp Z751YKVfILlPG4IuCtHAkhz3jn0uRSVpxUdxRaGJk6Sz1rEg8_7WJbc9qNVoN3wSej4fjb33jaJJ rXGmHooDP2G80.19OmV5WWZ9JCckqxvvdWOUY5R3Gocd89BcYCCZBkbB5_jMa6.mVr.3Z14l9RjJ X5.nDBdu9n1abCbrY1W1zlqG2rH81LDHzTtEiPanQbln8nGKLBu_eqeXikVSxrCwAniTsAnO9EXN Cjxt275oeb4H0ZPecVHXIKMUUfI2sXccRon7_bQS8i3yh1FnKV4u8tCQGl3AbUJAik6R_qQ_mx8D AO1S6mHejVBLdmAUbW4MiI.AzmvXSMKIwFTc0iDg.fJx32Ss9TVNRj3kca7WoZ.1HtlFwkTnYAqy D X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic303.consmr.mail.gq1.yahoo.com with HTTP; Thu, 16 Feb 2023 00:09:01 +0000 Received: by hermes--production-bf1-57c96c66f6-7l94f (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 8fd4965d3555d202b3e8b986700ee75b; Thu, 16 Feb 2023 00:08:58 +0000 (UTC) From: Mark Millard Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.300.101.1.3\)) Subject: RE: git: 6926e2699ae5 - main - arm: Add support for using VFP in kernel Message-Id: <3A143148-895F-472B-9AFB-5F1AA0FD1FA0@yahoo.com> Date: Wed, 15 Feb 2023 16:08:46 -0800 To: "kd@freebsd.org" , "wma@freebsd.org" , dev-commits-src-main@freebsd.org X-Mailer: Apple Mail (2.3731.300.101.1.3) References: <3A143148-895F-472B-9AFB-5F1AA0FD1FA0.ref@yahoo.com> X-Spamd-Result: default: False [-3.28 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.78)[-0.782]; MV_CASE(0.50)[]; DMARC_POLICY_ALLOW(-0.50)[yahoo.com,reject]; R_DKIM_ALLOW(-0.20)[yahoo.com:s=s2048]; R_SPF_ALLOW(-0.20)[+ptr:yahoo.com]; MIME_GOOD(-0.10)[text/plain]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; DWL_DNSWL_NONE(0.00)[yahoo.com:dkim]; TO_MATCH_ENVRCPT_SOME(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; ASN(0.00)[asn:36647, ipnet:98.137.64.0/20, country:US]; RCVD_IN_DNSWL_NONE(0.00)[98.137.64.206:from]; RCVD_COUNT_THREE(0.00)[3]; FREEMAIL_FROM(0.00)[yahoo.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_TLS_LAST(0.00)[]; DKIM_TRACE(0.00)[yahoo.com:+]; MIME_TRACE(0.00)[0:+]; FROM_EQ_ENVFROM(0.00)[]; FREEMAIL_ENVFROM(0.00)[yahoo.com]; MLMMJ_DEST(0.00)[dev-commits-src-main@freebsd.org] X-Rspamd-Queue-Id: 4PHFfl48S4z3yDb X-Spamd-Bar: --- X-ThisMailContainsUnwantedMimeParts: N Kornel Dul=C4=99ba wrote on Date: Sat, 04 Feb 2023 19:22:23 UTC : > The branch main has been updated by kd: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3D6926e2699ae55080f860488895a2a9aa= 6e6d9b4d >=20 > commit 6926e2699ae55080f860488895a2a9aa6e6d9b4d > Author: Kornel Dul=C4=99ba > AuthorDate: 2023-02-04 12:59:30 +0000 > Commit: Kornel Dul=C4=99ba > CommitDate: 2023-02-04 19:21:43 +0000 >=20 > arm: Add support for using VFP in kernel >=20 > Add missing logic to allow in-kernel VFP usage for ARMv7 NEON. > The implementation is strongly based on arm64 code. > It introduces a family of fpu_kern_* functions to enable the usage > of VFP instructions in kernel. > Apart from that the existing armv7 VFP logic was modified, > taking into account that the state of the VFP registers can now > be modified in the kernel. >=20 > Co-developed by: Wojciech Macek > Sponsored by: Stormshield > Obtained from: Semihalf > Reviewed by: andrew > Differential Revision: https://reviews.freebsd.org/D37419 > --- > lib/libthread_db/arch/arm/libpthread_md.c | 21 ++-- > sys/arm/arm/exec_machdep.c | 49 ++++---- > sys/arm/arm/machdep.c | 1 + > sys/arm/arm/machdep_kdb.c | 31 ++++- > sys/arm/arm/swtch-v6.S | 8 +- > sys/arm/arm/swtch.S | 8 +- > sys/arm/arm/vfp.c | 182 +++++++++++++++++++++++++++++- > sys/arm/arm/vm_machdep.c | 6 +- > sys/arm/include/fpu.h | 7 ++ > sys/arm/include/pcb.h | 5 + > sys/arm/include/reg.h | 12 +- > sys/arm/include/vfp.h | 17 +++ > 12 files changed, 293 insertions(+), 54 deletions(-) [This is a somewhat adjusted version of a note replying to a Warner note about a panic someone got during a process coredump that was happening.] Just a possible point, given recent kernel floating point work: I tried to do a typical build and test of some benchmark programs that I sometimes use that involve floating point in some of the programs, some use with multithreading involved. (As FreeBSD and g++ progress I tend to do this once and a while, not as often on armv7 as on aarch64.) On armv7, I now usually get a message about a failure of an internal cross-check, which also leads to the program being stopped early. The messaging from run to run varies what the failure is, but the runs should not vary and should not fail the cross-checks --and previously did not, including when I last tried armv7. (Not recently.) For the specific example failures, the initial serial (single thread) test with float involved works but the following multi-thread test in the same program fails and causes the program to stop when it notices there is a problem. (On occasion the cross-check does does not detect a problem.) The programs that do not test floating point do not fail. (Same algorithm on integral types.) These can involve floating point outside the algorithm benchmarked, but with no multi-threading involved for such and no floating point based cross-checks involved. At this point it is far from obvious to me how I would trackdown the specifics of what leads to the failed cross-checks. But the above is suggestive of there being problems for armv7 handling of saving and restoring floating point context for multi-threading in a process, at least. I've no clue if such are strictly limited to the floating point values that show up vs. if there might be wider memory handling problems that result in the process. =3D=3D=3D Mark Millard marklmi at yahoo.com