From owner-p4-projects@FreeBSD.ORG  Mon May 31 01:11:07 2010
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 5B2B61065672; Mon, 31 May 2010 01:11:07 +0000 (UTC)
Delivered-To: perforce@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 1FD791065679
	for <perforce@FreeBSD.org>; Mon, 31 May 2010 01:11:07 +0000 (UTC)
	(envelope-from gcooper@FreeBSD.org)
Received: from repoman.freebsd.org (unknown [IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id 0CB2C8FC14
	for <perforce@FreeBSD.org>; Mon, 31 May 2010 01:11:07 +0000 (UTC)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id o4V1B6Rt052611
	for <perforce@FreeBSD.org>; Mon, 31 May 2010 01:11:06 GMT
	(envelope-from gcooper@FreeBSD.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.3/8.14.3/Submit) id o4V1B63P052609
	for perforce@freebsd.org; Mon, 31 May 2010 01:11:06 GMT
	(envelope-from gcooper@FreeBSD.org)
Date: Mon, 31 May 2010 01:11:06 GMT
Message-Id: <201005310111.o4V1B63P052609@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	gcooper@FreeBSD.org using -f
From: Garrett Cooper <gcooper@FreeBSD.org>
To: Perforce Change Reviews <perforce@FreeBSD.org>
Precedence: bulk
Cc: 
Subject: PERFORCE change 178991 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 31 May 2010 01:11:07 -0000

http://p4web.freebsd.org/@@178991?ac=10

Change 178991 by gcooper@gcooper-bayonetta on 2010/05/31 01:10:16

	Add warnings about QA issues with plist_add*

Affected files ...

.. //depot/projects/soc2007/gcooper-pkg_install-enhancements-simplified/lib/libpkg/plist.c#9 edit

Differences ...

==== //depot/projects/soc2007/gcooper-pkg_install-enhancements-simplified/lib/libpkg/plist.c#9 (text+ko) ====

@@ -34,7 +34,12 @@
 
 #include "pkg.h"
 
-/* Add an item to a packing list */
+/*
+ * Add an item to a packing list
+ *
+ * FIXME: this will `silently fail' until the next point when p is
+ * dereferenced.
+ */
 void
 add_plist(Package *p, plist_t type, const char *arg)
 {
@@ -71,6 +76,10 @@
 
 }
 
+/*
+ * FIXME: this will `silently fail' until the next point when p is
+ * dereferenced.
+ */
 void
 add_plist_top(Package *p, plist_t type, const char *arg)
 {