From owner-svn-src-user@FreeBSD.ORG  Mon Sep 13 18:32:50 2010
Return-Path: <owner-svn-src-user@FreeBSD.ORG>
Delivered-To: svn-src-user@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 13AE91065675;
	Mon, 13 Sep 2010 18:32:50 +0000 (UTC)
	(envelope-from weongyo@FreeBSD.org)
Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c])
	by mx1.freebsd.org (Postfix) with ESMTP id 037518FC0A;
	Mon, 13 Sep 2010 18:32:50 +0000 (UTC)
Received: from svn.freebsd.org (localhost [127.0.0.1])
	by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id o8DIWnM7023942;
	Mon, 13 Sep 2010 18:32:49 GMT (envelope-from weongyo@svn.freebsd.org)
Received: (from weongyo@localhost)
	by svn.freebsd.org (8.14.3/8.14.3/Submit) id o8DIWnHV023940;
	Mon, 13 Sep 2010 18:32:49 GMT (envelope-from weongyo@svn.freebsd.org)
Message-Id: <201009131832.o8DIWnHV023940@svn.freebsd.org>
From: Weongyo Jeong <weongyo@FreeBSD.org>
Date: Mon, 13 Sep 2010 18:32:49 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-user@freebsd.org
X-SVN-Group: user
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Cc: 
Subject: svn commit: r212571 - user/weongyo/usb/sys/dev/usb/controller
X-BeenThere: svn-src-user@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the experimental &quot; user&quot;
	src tree" <svn-src-user.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-user>,
	<mailto:svn-src-user-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-user>
List-Post: <mailto:svn-src-user@freebsd.org>
List-Help: <mailto:svn-src-user-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-user>,
	<mailto:svn-src-user-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 13 Sep 2010 18:32:50 -0000

Author: weongyo
Date: Mon Sep 13 18:32:49 2010
New Revision: 212571
URL: http://svn.freebsd.org/changeset/base/212571

Log:
  Adds a XXX comment not sure that devclass_find(9) requires Giant
  holding.  Just looking the source code it looks it doesn't require it
  though it has a `devclasses' traversal loop.

Modified:
  user/weongyo/usb/sys/dev/usb/controller/usb_controller.c

Modified: user/weongyo/usb/sys/dev/usb/controller/usb_controller.c
==============================================================================
--- user/weongyo/usb/sys/dev/usb/controller/usb_controller.c	Mon Sep 13 18:26:34 2010	(r212570)
+++ user/weongyo/usb/sys/dev/usb/controller/usb_controller.c	Mon Sep 13 18:32:49 2010	(r212571)
@@ -394,6 +394,7 @@ usb_attach_sub(device_t dev, struct usb_
 {
 	const char *pname = device_get_nameunit(dev);
 
+	/* XXX devclass_find(9) needs Giant? */
 	GIANT_REQUIRED;
 	if (usb_devclass_ptr == NULL)
 		usb_devclass_ptr = devclass_find("usbus");