From owner-freebsd-net@FreeBSD.ORG Fri Aug 3 16:46:22 2012 Return-Path: Delivered-To: net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0B3811065673 for ; Fri, 3 Aug 2012 16:46:22 +0000 (UTC) (envelope-from jfvogel@gmail.com) Received: from mail-vb0-f54.google.com (mail-vb0-f54.google.com [209.85.212.54]) by mx1.freebsd.org (Postfix) with ESMTP id B4B288FC24 for ; Fri, 3 Aug 2012 16:46:21 +0000 (UTC) Received: by vbmv11 with SMTP id v11so1089055vbm.13 for ; Fri, 03 Aug 2012 09:46:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=w0LU1Sk1P8XeY9VwIjrm+dwT9p9pMuAFtGjlGpOuPx8=; b=Hf1tBbvM8oFCUYOmORZv39qnc/9zBHlJ7BzXKlwFVl0oV2t+EA9ko/od83eIt5vsjU YQTC6OsgCxbsPmSNWYZSww6GnztfSFcU6UsAtAByl8PZQZsQqWIQvXQws894U7Ju8WOA g5m1pHH7S8vWGoGheWlqtsM0WzJn350c4fwdm3OiXmwnqcJORMDMGM2r2KCsbFkugNtR 2MOiGHxpNYQ7f2kfFzwtN84rLH6Ah2RdZtFnz6dzsIAxUUwlvUT0xtWDgk63bq1q4ud2 yc4GrQRcSKSE9To4tz8qKdpngw7qbnFtdNEWOxKsxzUFO2Fn4tcuLkD8Eh26xO/aOWRj iZlg== MIME-Version: 1.0 Received: by 10.52.23.107 with SMTP id l11mr1630277vdf.6.1344012380730; Fri, 03 Aug 2012 09:46:20 -0700 (PDT) Received: by 10.58.187.225 with HTTP; Fri, 3 Aug 2012 09:46:20 -0700 (PDT) In-Reply-To: References: Date: Fri, 3 Aug 2012 09:46:20 -0700 Message-ID: From: Jack Vogel To: Vijay Singh Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: net@freebsd.org Subject: Re: question in ixgbe_legacy_irq X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Aug 2012 16:46:22 -0000 No, that's probably wrong, but was not noticed because the legacy interrupt path has been unused. The only time I've ever used it was during initial development and debug :) I'm taking the day off, but I'll take a closer look at the code shortly. Jack On Fri, Aug 3, 2012 at 9:19 AM, Vijay Singh wrote: > Folks, the ixgbe_legacy_irq() interrupt handler kicks the taskqueue if > there is more rx or tx. > > > 1440 if (more_rx || more_tx) > 1441 taskqueue_enqueue(que->tq, &que->que_task); > > But then it enables interrupts unconditionally: > > 1454 > 1455 ixgbe_enable_intr(adapter); > > Is this correct? > > -vijay > _______________________________________________ > freebsd-net@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" >