From owner-freebsd-cvsweb@FreeBSD.ORG  Mon Jun 23 14:37:11 2003
Return-Path: <owner-freebsd-cvsweb@FreeBSD.ORG>
Delivered-To: freebsd-cvsweb@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id B1CB637B401
	for <freebsd-cvsweb@FreeBSD.org>;
	Mon, 23 Jun 2003 14:37:11 -0700 (PDT)
Received: from smtp1.pp.htv.fi (smtp1.pp.htv.fi [212.90.64.111])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 1ACC643FDD
	for <freebsd-cvsweb@FreeBSD.org>;
	Mon, 23 Jun 2003 14:37:11 -0700 (PDT)
	(envelope-from scop@FreeBSD.org)
Received: from posti.pp.htv.fi (posti.pp.htv.fi [212.90.64.50])
	by smtp1.pp.htv.fi (Postfix) with ESMTP id 0551D7FEA6
	for <freebsd-cvsweb@FreeBSD.org>;
	Tue, 24 Jun 2003 00:37:10 +0300 (EEST)
Received: from cs78130147.pp.htv.fi (cs78130147.pp.htv.fi [62.78.130.147])
	by posti.pp.htv.fi (8.11.1/8.11.1) with ESMTP id h5NLdH928842
	for <freebsd-cvsweb@freebsd.org>;
	Tue, 24 Jun 2003 00:39:17 +0300 (EETDST)
From: Ville =?ISO-8859-1?Q?Skytt=E4?= <scop@FreeBSD.org>
To: freebsd-cvsweb@FreeBSD.org
In-Reply-To: <20030530174527.GA25625@bzz.taranis.org>
References: <20030530174527.GA25625@bzz.taranis.org>
Content-Type: text/plain; charset=ISO-8859-1
Organization: FreeBSD
Message-Id: <1056404228.23164.173.camel@bobcat.ods.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.2.2 (1.2.2-5) 
Date: 24 Jun 2003 00:37:09 +0300
Content-Transfer-Encoding: 8bit
Subject: Re: couple minor bugs [correct diff]
X-BeenThere: freebsd-cvsweb@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS Web maintenance mailing list [restricted posting]
	<freebsd-cvsweb.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-cvsweb>,
	<mailto:freebsd-cvsweb-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-cvsweb>
List-Post: <mailto:freebsd-cvsweb@freebsd.org>
List-Help: <mailto:freebsd-cvsweb-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-cvsweb>,
	<mailto:freebsd-cvsweb-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 23 Jun 2003 21:37:12 -0000

On Fri, 2003-05-30 at 20:45, Christophe Kalt wrote:

> You need to set stdout to be automatically flushed to avoid
> having a child (such as cvsgraph) flushing the same content
> as the parent a second time.
> 
> a "$| = 1;" well placed (may be in BEGIN) does the trick.

Hmm, there are multiple places where $| is fiddled with in cvsweb.cgi,
and placing that in BEGIN could have Side Effects...

I'm thinking about reworking the opens and pipes in cvsweb.cgi anyway
using IPC::Run so it would work with mod_perl 1.99+ as well.

> The attached diff also fixes a small problem with DoGraphView.

Applied, thanks.

> Finally, having working annotations w/o read-write access is
> awesome, finally, thanks!  You may want to update the comments
> for $allow_annotate.

Done, thanks for the heads up.

Cheers,
-- 
\/ille Skyttä
scop at FreeBSD.org