From owner-svn-src-head@freebsd.org Fri Jul 6 01:45:35 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8DBA0102772D; Fri, 6 Jul 2018 01:45:35 +0000 (UTC) (envelope-from mat.macy@gmail.com) Received: from mail-io0-x230.google.com (mail-io0-x230.google.com [IPv6:2607:f8b0:4001:c06::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1EC0381F78; Fri, 6 Jul 2018 01:45:35 +0000 (UTC) (envelope-from mat.macy@gmail.com) Received: by mail-io0-x230.google.com with SMTP id q4-v6so9500336iob.2; Thu, 05 Jul 2018 18:45:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=9XIN1Wgrv0koysbZafMb8OI8HN/3JtWPixzjZRWiIQY=; b=NTFFgi9XLddyJue42rY2a/BeHU9/0Aq/zPyhZhJBOkY+xZbyT4XwMEGltkxHITmsEQ w/cqrYNgP39E51VVX8NKydanRSZrmy72jBTLeKDhnFj12fhD/J4DVdvvYxQGr5qnFdJz mDCrBO9f8PlSFnghAvUUr8SfJ9fhUdoXVYOPcIiOIaSZ0e52s/5ITuyaxdUedWnsWV5C tsOU/R4REoz0pFfhPHQtzZUE1zJF3n7JzbExaESCT681zuxcAHuwVTlGa1BFzYj+cM0L c92WHGd3b0eXARwbR7tKB6de7R+ZYzvO6sY7f1nnowe+pPRh7QpR4CbMHU4s4AyA7fSL tMgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=9XIN1Wgrv0koysbZafMb8OI8HN/3JtWPixzjZRWiIQY=; b=KtrzpbFHr0qGaS8vZCW/WAfCrdwMLnpHPleJFX85SfWoBfWf5qBceCSipH91dnuX2I FI9gxOB2rSpIOxdaIyOAwcC2cxkrMf5qz/yM0GMbBMxvO69pt5MVuSYiCzP/k8lkUENV c834GqvPi/EgZt581DKF5374JN/AycPNg3GOwOXMCpkUHxVd/u/X0bwseEW9LCqrUrCi H8LWGFghjIm3QBEHzrP9z7VRno9O9drCpqz7T3VKJJ9NFukdQerO777KwrorZGpMUhe7 nikbSA3QMrHq8BehfDOPFyiVtrKJQ0664TDf10Vz2ODDbjlOmh2hTkrAL30NDEuDfdFI 1y0w== X-Gm-Message-State: APt69E2pe6IJBc6xdJ2YySkYSbLpSg8VKxeBnUgw4a0Oa6tl6oHY3fcS 1uo4FAA8Ii/acfwmN/OiiCe5x5jO1p90RiO1JJA= X-Google-Smtp-Source: AAOMgpdZdKSyVyU9bjSekOm4X3j9vSnIRZggaqcreN3DX1ZlS8tanYNXY3jywxdg1ok2pjA6ASLvyegxQhNWtOSIr3M= X-Received: by 2002:a6b:5a08:: with SMTP id o8-v6mr6906722iob.5.1530841534262; Thu, 05 Jul 2018 18:45:34 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a02:8d2:0:0:0:0:0 with HTTP; Thu, 5 Jul 2018 18:45:33 -0700 (PDT) In-Reply-To: <20180705163338.GA67089@spindle.one-eyed-alien.net> References: <201807051313.w65DDnQJ041281@repo.freebsd.org> <20180705163338.GA67089@spindle.one-eyed-alien.net> From: Matthew Macy Date: Thu, 5 Jul 2018 18:45:33 -0700 Message-ID: Subject: Re: svn commit: r335979 - in head: . lib/libkvm sys/kern sys/netinet sys/sys usr.bin/netstat usr.bin/sockstat To: Brooks Davis Cc: Ravi Pokala , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Jul 2018 01:45:35 -0000 this breaks the MIPS builds. On Thu, Jul 5, 2018 at 9:33 AM, Brooks Davis wrote: > On Thu, Jul 05, 2018 at 09:10:54AM -0700, Ravi Pokala wrote: >> Hi Brooks, >> >> -----Original Message----- >> From: on behalf of Brooks Davis >> Date: 2018-07-05, Thursday at 06:13 >> To: , , >> Subject: svn commit: r335979 - in head: . lib/libkvm sys/kern sys/netinet sys/sys usr.bin/netstat usr.bin/sockstat >> >> > Author: brooks >> > Date: Thu Jul 5 13:13:48 2018 >> > New Revision: 335979 >> > URL: https://svnweb.freebsd.org/changeset/base/335979 >> > >> > Log: >> > Make struct xinpcb and friends word-size independent. >> > >> > Replace size_t members with ksize_t (uint64_t) and pointer members >> > (never used as pointers in userspace, but instead as unique >> > idenitifiers) with kvaddr_t (uint64_t). This makes the structs >> > identical between 32-bit and 64-bit ABIs. >> ... >> > Modified: head/UPDATING >> > ============================================================================== >> > --- head/UPDATING Thu Jul 5 11:50:59 2018 (r335978) >> > +++ head/UPDATING Thu Jul 5 13:13:48 2018 (r335979) >> > @@ -31,6 +31,14 @@ NOTE TO PEOPLE WHO THINK THAT FreeBSD 12.x IS SLOW: >> > disable the most expensive debugging functionality run >> > "ln -s 'abort:false,junk:false' /etc/malloc.conf".) >> > >> > +20180705: >> > + The ABI of syscalls used by management tools like sockstat and >> > + netstat has been broken to allow 32-bit binaries to work on >> > + 64-bit kernels without modification. >> >> Isn't that what the compat32 layer is for? > > compat32 isn't magic. If one tried, one could hardly design structures > to make 32-bit compat harder then the previous versions. It's certainly > possible to make work, but quite annoying. Since the ABI of most these > structures was already broken for 12, I chose this approach as it is > quite trivial. > >> > These programs will need >> > + to match the kernel in order to function. External programs may >> > + require minor modifications to accommodate a change of type in >> > + structures from pointers to 64-bit virtual addresses. >> >> Doesn't this contradict the earlier statement about letting things run unmodified? > > Unmodified post this commit. We already don't support netstat and > sockstat from 11 on 12 in any architecture combination. > > -- Brooks