From nobody Sun Feb 8 20:55:21 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4f8Kq13qW4z6Rkry for ; Sun, 08 Feb 2026 20:55:41 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pf1-x442.google.com (mail-pf1-x442.google.com [IPv6:2607:f8b0:4864:20::442]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4f8Kpz0C8Vz4LLr for ; Sun, 08 Feb 2026 20:55:39 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20230601 header.b=FFY1DXZC; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of yaneurabeya@gmail.com designates 2607:f8b0:4864:20::442 as permitted sender) smtp.mailfrom=yaneurabeya@gmail.com Received: by mail-pf1-x442.google.com with SMTP id d2e1a72fcca58-823f9f81da5so1932642b3a.1 for ; Sun, 08 Feb 2026 12:55:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770584133; x=1771188933; darn=freebsd.org; h=to:references:message-id:cc:date:in-reply-to:from:subject :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=XQ7ukg8OI38POJ0rSaAhkIWpi5UNcYg7qeAaQUzsJtc=; b=FFY1DXZCAwJCpy6OcnPX3U2MX3yC39GLIl7ZpJL6amv0H6DcyN9lNaOzoUGeFTVaaa Zgf/qAAtZODvjE5n8we2BjhQkoLs4lUb4IC/cWzkUg1ZkZDIULn/zZcshBrOJYHq9jyx 0jFyyTMlv9hndZ4oMKh1uyunFsq0gb5CYWB+XloGns4jovorckTUPkCTLdA74Aj4wRJc jDOeucQPi8lhIjwzPA45Xqjs9pWGB0tWFuAiTpLK05A0upj70N2y0sQiZjHno/DvJKIJ m3CKF69zzdIFNDvdidAtvyhFfsFlIgkZgmiZ4txiNrmovBpf0HGdJNo6qiBfWlburStA XtJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770584133; x=1771188933; h=to:references:message-id:cc:date:in-reply-to:from:subject :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=XQ7ukg8OI38POJ0rSaAhkIWpi5UNcYg7qeAaQUzsJtc=; b=ZTEP3wC1JSOP4ePLS4aIfRFBkDFH53zXdXRO7Qp91yjiveJGiLIjkT/z/SR8gcdX8I i7IM4PusBxerICn1FihNuFnFVAGY8SOPVYgLLfImSNWqyD1LxO24H/6//PTAySz/L9MI O8Sxfsm8sYOPoWrWzGghF5DcPG0qYapY4/hPq2KCDT56L+PzST1Xgl7/JsZEwxbZFk84 LLdej4xIGu6FGpUoha7KbpKCUJXHxnB3v/j9t/ENzf0/av2//rWbQDBdh7150OQ00a/M +8jf+2ukba8pzYZhpx/VGghz/NGBNe3Be2UlChXBlhAp1d1iZqiwWYVyc1Ju2bcgnCkb sJgQ== X-Forwarded-Encrypted: i=1; AJvYcCXNpP4cK/XadYSim7Ve/WLttY/T1NsZOX7rwhaowCjqpdVuDQzcxFL5jm7MWM5JBALhyI7WqVde/scTNnlHiQYlM7ZDETw7agg=@freebsd.org X-Gm-Message-State: AOJu0Yz2RGf2PgiEDvgQczZotJIHep6LqYynx8ul7KNf5Ji/D7lpABO5 v/bRYWOEAxklwGoFjIkbMJnWj8KxrsCxtojCxZFuutvmKk6KTdO9X+yfLmDd/rSJGN8= X-Gm-Gg: AZuq6aIaKJXdhnpKcFyYW77qyIzPjkokFOEyyeN3QGyEcQXvG6qJXOJdbEJKafdfufw PsoI4j3BqmjtEcMNHzgssbSlyZS/mEBMNJ1dtRrI0BOmcCqFJxFlb5FXTVdK4zLkjwZKzuY0Y0U 603uA5ArfE2cBHQXFQbxG0wB4Jk/16InjlSsnvhVIj5MFTVBlGfB596vB4s9npNdcncuRvhOBuC N+9mL9nR2CfYll+UYvmMK+GEwZ/gyClCVwI4sJGKADqwndYRJi+hjkhI5/avZzucrxODeBzpEnb zKkc+iBZ1Tr+OvZUR2T52GT3OhCT0x3TMFDnFkSLicvxFDhVFZBiHpywCItH+uUj5T7wGZ2/cSM 2eAPhGtwttT9TQeGYKf5MyPf7R4HnzYBoYm1boLIrv8nC+kvxmRdSnwET11nnVLj1BkDi3/2smP iTR67kOp8ghdtXBa5cWI2cxeKmxx0= X-Received: by 2002:a05:6a00:2d82:b0:81f:9f41:34bb with SMTP id d2e1a72fcca58-82441798918mr8181643b3a.56.1770584132771; Sun, 08 Feb 2026 12:55:32 -0800 (PST) Received: from smtpclient.apple ([176.100.43.7]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8245a9c1b6asm4253935b3a.64.2026.02.08.12.55.31 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 08 Feb 2026 12:55:32 -0800 (PST) Content-Type: multipart/signed; boundary="Apple-Mail=_28F86C0E-7A0B-463C-9F59-3C56CBDF79F9"; protocol="application/pgp-signature"; micalg=pgp-sha256 List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.700.81.1.3\)) Subject: Re: git: 70aab985c300 - stable/15 - heimdal: Pass the correct pointer to free in an error case From: "Enji Cooper (yaneurabeya)" In-Reply-To: <11d5cb2d-7460-4bd9-a33c-e52343f30d1d@FreeBSD.org> Date: Sun, 8 Feb 2026 12:55:21 -0800 Cc: Enji Cooper , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-branches@freebsd.org" Message-Id: <1485E40C-2752-4207-972A-E56FD5C8E270@gmail.com> References: <6982480e.3097b.628edb67@gitrepo.freebsd.org> <11d5cb2d-7460-4bd9-a33c-e52343f30d1d@FreeBSD.org> To: John Baldwin X-Mailer: Apple Mail (2.3826.700.81.1.3) X-Spamd-Result: default: False [-5.60 / 15.00]; SIGNED_PGP(-2.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-1.000]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; MV_CASE(0.50)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36:c]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20230601]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; TO_DN_EQ_ADDR_SOME(0.00)[]; FREEMAIL_FROM(0.00)[gmail.com]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ARC_NA(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_TLS_LAST(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; FROM_HAS_DN(0.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; HAS_ATTACHMENT(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-branches@freebsd.org]; MID_RHS_MATCH_FROM(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-src-branches@freebsd.org]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::442:from]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_FIVE(0.00)[5] X-Rspamd-Queue-Id: 4f8Kpz0C8Vz4LLr X-Spamd-Bar: ----- --Apple-Mail=_28F86C0E-7A0B-463C-9F59-3C56CBDF79F9 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Feb 6, 2026, at 6:41=E2=80=AFAM, John Baldwin = wrote: >=20 > On 2/3/26 14:10, Enji Cooper wrote: >> The branch stable/15 has been updated by ngie: >> URL: = https://cgit.FreeBSD.org/src/commit/?id=3D70aab985c30092483b5b32cdd3750570= ec3d9364 >> commit 70aab985c30092483b5b32cdd3750570ec3d9364 >> Author: John Baldwin >> AuthorDate: 2026-01-31 17:00:44 +0000 >> Commit: Enji Cooper >> CommitDate: 2026-02-03 19:09:55 +0000 >> heimdal: Pass the correct pointer to free in an error case >> This fixes a warning reported by GCC 14 on stable/14: >> crypto/heimdal/lib/hdb/keys.c:241:13: warning: 'free' called = on pointer 'ext' with nonzero offset 16 [-Wfree-nonheap-object] >> 241 | free(hist_keys); >> | ^~~~~~~~~~~~~~~ >> crypto/heimdal/lib/hdb/keys.c:234:15: note: returned from = 'calloc' >> 234 | ext =3D calloc(1, sizeof (*ext)); >> | ^~~~~~~~~~~~~~~~~~~~~~~~ >> Reviewed by: rmacklem, cy >> Fixes: 5000d023a446 ("heimdal-kadmin: Add support for = the -f dump option") >> Differential Revision: https://reviews.freebsd.org/D54932 >> (cherry picked from commit = b26a7af438f36dcde86f39a681123cc2140affb2) >=20 > Why so eager to MFC all the heimdal fixes before the normal time? = They aren't even compiled > on stable/15 by default? These were at least 3 days later, but I = think the last one I > committed you merged the next day which seemed a bit odd. Sorry =E2=80=94 I jumped the gun looking at the date after I merged the = change :/. I was trying to get rid of the build error emails and your = change made sense. -Enji= --Apple-Mail=_28F86C0E-7A0B-463C-9F59-3C56CBDF79F9 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEkHfexGRJ3gYRdA2gGpE5DjPsNJgFAmmI+DkACgkQGpE5DjPs NJjmzQ//SOkowHV35bzbUmejmVX24xoFyO9flgcdLFSTsiBuEpB1nvGWlRipHzk+ yJH2C4AwytaeSGvY9FyHuHzbVuV7zq4Pcd+BEI6WwZGYidD855Z2+AfYfu05VAv9 +ciskuBVjKI2AYSv1F6oecc7NVmdxdGFL+KzMbOxWJF2aB2ERD6yVEj0/xO6FwPP mRs67X6ipDsVMidd3qY8M5G5dLfNPklflUpxA4FR9gAkVGbsvL9G22R+KH4x4G6u oOtVyswTNlU1llxHdavHi5m1wkOa0J7mJzsVhDq6icGLKwcq/QzJ/bUka1/flNZo wBpvEY74S+Zg2G4L/MmS3XrrmH7zbsLG2olURPLnp88C6lHNjBM5L3/8QfVXMMNV gcM4QKWjXhPttWj3QiEpiqvrEyquYy0DlTQWYrGaYZd9tCxG8GOVUJFR8KnQQ7Kv am5BFeoyhJ2mR/je+kyL/1tDV6IhSiYsSgnIjyZ16v0da0dHdEF4O04BSCNL8BaR WR9cdawKLIEjSooawzJGq3E0wiZPh6iWlk9tCEPMAFRGpcUmZBjV9uzUgm5lgYMV jw1Bwr+lm0hDGpoicvvQF2/UZqcpcryf7UxhH54GClhQY8LkHu5QBDdpAYMpESRx S+PC4gHc6IlTCY7bL5CSVtX0PonQ7uzowZ7h7TrZp+Ji7F3Q+C8= =Q8aq -----END PGP SIGNATURE----- --Apple-Mail=_28F86C0E-7A0B-463C-9F59-3C56CBDF79F9--