From owner-svn-ports-all@freebsd.org  Wed Jan  3 07:57:45 2018
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8B887EB2999;
 Wed,  3 Jan 2018 07:57:45 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 6A18968DB6;
 Wed,  3 Jan 2018 07:57:45 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id B26701F67F; Wed,  3 Jan 2018 07:57:44 +0000 (UTC)
Date: Wed, 3 Jan 2018 07:57:44 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Steve Wills <swills@FreeBSD.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r457907 - in head/net/rubygem-grpc: . files
Message-ID: <20180103075744.GA2731@FreeBSD.org>
References: <201801021606.w02G6xxJ033897@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="a8Wt8u1KmwUX3Y2C"
Content-Disposition: inline
In-Reply-To: <201801021606.w02G6xxJ033897@repo.freebsd.org>
User-Agent: Mutt/1.9.2 (2017-12-15)
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 03 Jan 2018 07:57:45 -0000


--a8Wt8u1KmwUX3Y2C
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Jan 02, 2018 at 04:06:59PM +0000, Steve Wills wrote:
> New Revision: 457907
> URL: https://svnweb.freebsd.org/changeset/ports/457907
> 
> Log:
>   net/rubygem-grpc: update to 1.8.0
>   
>   PR:		224800
>   Approved by:	Matthias Fechner <idefix@fechner.net> (maintainer)
> 
> Modified:
>   head/net/rubygem-grpc/Makefile   (contents, props changed)
>   head/net/rubygem-grpc/distinfo   (contents, props changed)
>   head/net/rubygem-grpc/files/grpc.gemspec

Would you consider patching grpc.gemspec with sed(1) instead?  It is
not particularly pretty, but not as ugly as 10K pre-generated binary
file with messed up svn properties.

It also places ${RM} -r of those files and directories and subsequent
grpc.gemspec fixup closer together (rather than one part done in the
`post-extract' target and fixup ... well, somewhere else).

It produces exactly the same result as current `files/grpc.gemspec'.

./danfe

--a8Wt8u1KmwUX3Y2C
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="grpc.diff"

Index: Makefile
===================================================================
--- Makefile	(revision 457946)
+++ Makefile	(working copy)
@@ -30,9 +30,11 @@
 post-extract:
 	@${RM} -r ${WRKSRC}/include ${WRKSRC}/third_party ${WRKSRC}/src/boringssl \
 		${WRKSRC}/src/core ${WRKSRC}/Makefile ${WRKSRC}/.yardopts ${WRKSRC}/etc
-	@${CP} ${FILESDIR}/grpc.gemspec ${WRKSRC}
 
 post-patch:
 	@${REINPLACE_CMD} 's,%%LOCALBASE%%,${LOCALBASE},' ${WRKSRC}/src/ruby/lib/grpc.rb
+	@${REINPLACE_CMD} -E '/s\.files = /s;, "(Makefile|etc|include|third_party|src/boringssl|src/core)[^"]*"\.freeze;;g' \
+		${WRKSRC}/grpc.gemspec
+	@${REINPLACE_CMD} -e '/s\.files = /s;"\.yardopts"\.freeze, ;;' ${WRKSRC}/grpc.gemspec
 
 .include <bsd.port.mk>

--a8Wt8u1KmwUX3Y2C--