From owner-svn-src-head@FreeBSD.ORG Fri May 1 19:09:14 2015 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 2C9ABD18 for ; Fri, 1 May 2015 19:09:14 +0000 (UTC) Received: from nm5-vm0.bullet.mail.bf1.yahoo.com (nm5-vm0.bullet.mail.bf1.yahoo.com [98.139.213.150]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id DE9E41FC7 for ; Fri, 1 May 2015 19:09:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1430506980; bh=iKvW+I0h+0Ka2Y7BqeTTSRVJ89KwI9TcGdSAHYGXx3I=; h=Date:From:To:Subject:References:In-Reply-To:From:Subject; b=moqOr3zMgAahED6HMjTPPI5yo2GV89x8nC3mumv5he1QeMJMHzsTgIkRYQ0UtbpHss6Mvjb0qrpqyPYk07tKm//aTh5GaKjW8MZawlZ7/bETFwkIusXP9vn3oh9MMyV4GE9PSJQ/aXtjjWmnzBZv75nmVkzyfuPIgbEXVO1+8/M5usmOJw3y44V1y/zOXBGkNyy6tkNNyd5bqi2US4SvCjXXzc0ug75U4DyaZ001G3GbO/0bbgEA0HP3qCuQWP9O5BtN6ZwXo5lj5bebzpo0Anq0OaXi5F7JrK4/LTdqdD5cgrQRn7n/xCBIilkuUtFfYD0LihohcqdWHVMbNmZKOg== Received: from [66.196.81.172] by nm5.bullet.mail.bf1.yahoo.com with NNFMP; 01 May 2015 19:03:00 -0000 Received: from [68.142.230.76] by tm18.bullet.mail.bf1.yahoo.com with NNFMP; 01 May 2015 19:03:00 -0000 Received: from [127.0.0.1] by smtp233.mail.bf1.yahoo.com with NNFMP; 01 May 2015 19:03:00 -0000 X-Yahoo-Newman-Id: 883890.88086.bm@smtp233.mail.bf1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: BaZMBQ0VM1kvvdHPrqs.6dnaeAblr2SEjan2DFT8BfFvDx5 c2a.8Qy0WNO2qdaa5we6nDHX18qfwxlRwIMJ5bdzAkpeP71ryc0zM0CtVlwD Vu3ogMpvl34NO2b0odfisGenX4bsJXt4nIcLjBQTi9XjvudUTJXEIxfSnA0j OsNyvMivrbyGBfwUrT3X5jZ2q43HpZW5RUgFNrtGLs1jRH4f5PBtF_M99rCk hCk1_OLw43XM8AeRes3eYiqQ8dN1RbVepzmBLO.8bejNpybz2Woz4Bp6wGVS jo7yvQjA7EpV4jbxUcWESHnqsvBwieH5c3CYGHsRUGMThbJg2gY25S7EKe.R E017hJBAjSzxc.Qs_MA9iB4MP0ZhejJXoFPSL3ZXFajxap_WEZ6E0_xCry9E ho_na9Ujk41mvb1NTcXikBPxrMLoHEdRX6kBcBT5qdGCE_7BX2_HoI0CzoGV xw.z4JYpFnwYqhUfNFu1g_GyXk00eZIyX.roM4pQcg.bpgTUy7netfAKdIJP T9Er3j7cMvRH0cAhOG2F3HGDmv5VIe.hv X-Yahoo-SMTP: xcjD0guswBAZaPPIbxpWwLcp9Unf Message-ID: <5543CDD9.4050902@FreeBSD.org> Date: Fri, 01 May 2015 14:02:49 -0500 From: Pedro Giffuni User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Baptiste Daroussin , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r282314 - in head: include lib/libc/stdlib References: <201505011832.t41IWGSs002284@svn.freebsd.org> In-Reply-To: <201505011832.t41IWGSs002284@svn.freebsd.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 May 2015 19:09:14 -0000 Hi; Sorry that I missed the review ... On 05/01/15 13:32, Baptiste Daroussin wrote: > ... > Modified: head/include/stdlib.h > ============================================================================== > --- head/include/stdlib.h Fri May 1 18:07:18 2015 (r282313) > +++ head/include/stdlib.h Fri May 1 18:32:16 2015 (r282314) > @@ -111,6 +111,9 @@ long double > strtold(const char * __restrict, char ** __restrict); > unsigned long > strtoul(const char * __restrict, char ** __restrict, int); > +#ifdef __BSD_VISIBLE > +void *reallocarray(void *, size_t, size_t); > +#endif > int system(const char *); > int wctomb(char *, wchar_t); > size_t wcstombs(char * __restrict, const wchar_t * __restrict, size_t); Please move it to the _BSD_VISIBLE section, along with reallocf. Also please add the __alloc_size attributes[1] while there. For the record, I dislike adding this non-standard function, especially considering that NetBSD added yet another variant, but I guess it helps importing new stuff from OpenBSD. Pedro. [1] It should be __result_use_check __alloc_size(2) __alloc_size(3)