From owner-svn-src-all@freebsd.org Wed May 23 13:49:21 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D9EB5EFE123 for ; Wed, 23 May 2018 13:49:21 +0000 (UTC) (envelope-from eadler@freebsd.org) Received: from smtp.freebsd.org (unknown [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8647B6B7BC for ; Wed, 23 May 2018 13:49:21 +0000 (UTC) (envelope-from eadler@freebsd.org) Received: from mail-yw0-f176.google.com (mail-yw0-f176.google.com [209.85.161.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) (Authenticated sender: eadler) by smtp.freebsd.org (Postfix) with ESMTPSA id 4D7AC82B3 for ; Wed, 23 May 2018 13:49:21 +0000 (UTC) (envelope-from eadler@freebsd.org) Received: by mail-yw0-f176.google.com with SMTP id h11-v6so5925208ywc.8 for ; Wed, 23 May 2018 06:49:21 -0700 (PDT) X-Gm-Message-State: ALKqPweWF8HV09MhCPeEQBmNSJO3FxdgA8JOVD3b+Tpr8JIf7Djf5fiq ucf91x9WmYUQogkaRSLEbqdrJE3RPZArx433Xbz1zg== X-Google-Smtp-Source: AB8JxZqdF9LejzTs14OKCp73KkKCY/W0CnCNrq8cseg0+6BFhrtJhL8HRZz6w7d7sqKFJLZ0sBFNYhPbIorAMJ4Nhls= X-Received: by 2002:a81:af26:: with SMTP id n38-v6mr1486703ywh.113.1527083360725; Wed, 23 May 2018 06:49:20 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a25:c709:0:0:0:0:0 with HTTP; Wed, 23 May 2018 06:48:50 -0700 (PDT) In-Reply-To: References: <201805230739.w4N7d5Z1062496@repo.freebsd.org> From: Eitan Adler Date: Wed, 23 May 2018 06:48:50 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r334078 - head/sbin/devd To: Warner Losh Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 May 2018 13:49:22 -0000 On 23 May 2018 at 06:35, Warner Losh wrote: > > > On Wed, May 23, 2018 at 1:39 AM, Eitan Adler wrote: >> >> Author: eadler >> Date: Wed May 23 07:39:05 2018 >> New Revision: 334078 >> URL: https://svnweb.freebsd.org/changeset/base/334078 >> >> Log: >> devd: compile at WARNS=6 >> >> Verified with "make universe TARGETS='amd64 arm arm64 i386 sparc64'" >> >> Modified: >> head/sbin/devd/Makefile >> head/sbin/devd/devd.cc >> head/sbin/devd/token.l >> > ... >> >> Modified: head/sbin/devd/token.l >> >> ============================================================================== >> --- head/sbin/devd/token.l Wed May 23 07:39:02 2018 (r334077) >> +++ head/sbin/devd/token.l Wed May 23 07:39:05 2018 (r334078) >> @@ -38,6 +38,7 @@ >> #include "devd.h" >> #include "y.tab.h" >> >> +extern int lineno; >> int lineno = 1; >> >> static void > > > This is completely bogus. Never ever ever just put extern in the line > before to avoid the warning. That's wrong 100% of the time. You're right. thanks for the reminder. See r334095 -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams