From owner-freebsd-current@FreeBSD.ORG Wed Aug 25 14:44:01 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7C0D116A4CE for ; Wed, 25 Aug 2004 14:44:01 +0000 (GMT) Received: from mail2.speakeasy.net (mail2.speakeasy.net [216.254.0.202]) by mx1.FreeBSD.org (Postfix) with ESMTP id 576AD43D31 for ; Wed, 25 Aug 2004 14:44:01 +0000 (GMT) (envelope-from jmg@hydrogen.funkthat.com) Received: (qmail 327 invoked from network); 25 Aug 2004 14:44:00 -0000 Received: from gate.funkthat.com (HELO hydrogen.funkthat.com) ([69.17.45.168]) (envelope-sender ) by mail2.speakeasy.net (qmail-ldap-1.03) with SMTP for ; 25 Aug 2004 14:44:00 -0000 Received: from hydrogen.funkthat.com (ryjgxw@localhost.funkthat.com [127.0.0.1])i7PEhxuU001743; Wed, 25 Aug 2004 07:44:00 -0700 (PDT) (envelope-from jmg@hydrogen.funkthat.com) Received: (from jmg@localhost) by hydrogen.funkthat.com (8.12.10/8.12.10/Submit) id i7PEhwiB001742; Wed, 25 Aug 2004 07:43:58 -0700 (PDT) Date: Wed, 25 Aug 2004 07:43:58 -0700 From: John-Mark Gurney To: Marius =?iso-8859-1?Q?N=FCnnerich?= Message-ID: <20040825144358.GM29902@funkthat.com> Mail-Followup-To: Marius =?iso-8859-1?Q?N=FCnnerich?= , freebsd-current@freebsd.org References: <20040823223036.472c88aa@duron.hackerzberg.dyndns.org> <20040824182034.GH29902@funkthat.com> <20040825024737.391169dd@duron.hackerzberg.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20040825024737.391169dd@duron.hackerzberg.dyndns.org> User-Agent: Mutt/1.4.1i X-Operating-System: FreeBSD 4.2-RELEASE i386 X-PGP-Fingerprint: B7 EC EF F8 AE ED A7 31 96 7A 22 B3 D8 56 36 F4 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html cc: freebsd-current@freebsd.org Subject: Re: LOR re0 and acpi X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: John-Mark Gurney List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Aug 2004 14:44:01 -0000 Marius Nünnerich wrote this message on Wed, Aug 25, 2004 at 02:47 +0200: > On Tue, 24 Aug 2004 11:20:34 -0700 > John-Mark Gurney wrote: > > > > I happen to have recently purchased a card, and ran across the same > > LOR... Try the attached patch. It works for me.. > > The patch works here too, thanks. But is it OK to simply remove that lock? Yes. The device isn't attached yet, so no one else should have a reference to the softc, and the lock is initalized and destroy in just a few lines, so there really is nothing that the lock locks. It might be useful if asserts are added to the CSR_READ_4 macro, but that probably won't happen since it's just a wrapper around a bus_space_ macro.. > > Next step is to lock down the driver.. :) > > I would love to, but I have no skills in this sector :( Don't worry, I'm working on merging bms's changes to rl into the re driver. -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not."