Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 28 Feb 2020 21:16:01 +0000
From:      Brooks Davis <brooks@freebsd.org>
To:        Warner Losh <imp@FreeBSD.org>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r358416 - head/sys/sys
Message-ID:  <20200228211601.GC48231@spindle.one-eyed-alien.net>
In-Reply-To: <202002280102.01S1223Q036983@repo.freebsd.org>
References:  <202002280102.01S1223Q036983@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--lCAWRPmW1mITcIfM
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Feb 28, 2020 at 01:02:02AM +0000, Warner Losh wrote:
> Author: imp
> Date: Fri Feb 28 01:02:01 2020
> New Revision: 358416
> URL: https://svnweb.freebsd.org/changeset/base/358416
>=20
> Log:
>   Remove duplicated ATA_CHECK_POWER_MODE
>=20
> Modified:
>   head/sys/sys/ata.h
>=20
> Modified: head/sys/sys/ata.h
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> --- head/sys/sys/ata.h	Fri Feb 28 00:42:27 2020	(r358415)
> +++ head/sys/sys/ata.h	Fri Feb 28 01:02:01 2020	(r358416)
> @@ -507,7 +507,6 @@ struct ata_params {
>  #define         ATA_SF_DIS_SRVIRQ       0xde    /* disable service inter=
rupt */
>  #define 	ATA_SF_LPSAERC		0x62	/* Long Phys Sect Align ErrRep*/
>  #define 	ATA_SF_DSN		0x63	/* Device Stats Notification */
> -#define ATA_CHECK_POWER_MODE		0xe5	/* Check Power Mode */
>  #define ATA_SECURITY_SET_PASSWORD       0xf1    /* set drive password */
>  #define ATA_SECURITY_UNLOCK             0xf2    /* unlock drive using pa=
sswd */
>  #define ATA_SECURITY_ERASE_PREPARE      0xf3    /* prepare to erase driv=
e */
>=20

I know that's not that you were working on, but that's a remarkable
collection of whitespace decisions in the remaining lines.

-- Brooks

--lCAWRPmW1mITcIfM
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEcBAEBAgAGBQJeWYMQAAoJEKzQXbSebgfAmtAH/jJ3qHhgihOuOQvcwFkfVWD4
GpUfA/Upa3Cn4AkT7iND8NcssBShz5FvF1P/V1A68tu64fDOMk8rxHiBMUVZY9jh
NOTXtbj0wr0YZKK0RobSV03EV8ydSvW4bPmTdfpQArOmAAbPKyrW2ez7NaC+wJFC
knAay+97BJRzwcfqVpPH1Z+wP6HXyphvMVTguFwU4rROG5+MbOg2Hf34ZwOurQgR
JtFjW2seHQkQzod8icuMiqI3CSGwYvfUo03WuA1iaMedoq6SM2c9IrDKKdKrGAEM
BYKCvflJFg6WleCcFGSfjD2wDjSdiEv5rWHnCSrHxRYEJWuYAyR87Ra0lOWmQpY=
=S6nb
-----END PGP SIGNATURE-----

--lCAWRPmW1mITcIfM--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20200228211601.GC48231>