Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 16 Oct 2025 00:35:04 GMT
From:      Jose Luis Duran <jlduran@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
Subject:   git: 7161c525abff - stable/15 - openssh: blocklist: Remove non async-signal safe probe
Message-ID:  <202510160035.59G0Z4tX011650@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch stable/15 has been updated by jlduran:

URL: https://cgit.FreeBSD.org/src/commit/?id=7161c525abffe6cdb19ac01223d058fcbabf49c5

commit 7161c525abffe6cdb19ac01223d058fcbabf49c5
Author:     Jose Luis Duran <jlduran@FreeBSD.org>
AuthorDate: 2025-10-15 13:29:30 +0000
Commit:     Jose Luis Duran <jlduran@FreeBSD.org>
CommitDate: 2025-10-16 00:30:07 +0000

    openssh: blocklist: Remove non async-signal safe probe
    
    BLOCKLIST_NOTIFY() is called within a signal handler for the alarm after
    the grace period has expired that may only take async-signal safe
    actions.
    
    Reviewed by:    emaste
    Fixes:          e02003bce726 ("openssh: blocklist: Use NetBSD probes")
    MFC after:      1 day
    Differential Revision:  https://reviews.freebsd.org/D53109
    
    (cherry picked from commit 9c82c17c2a3ac61a69cb5337cb6f92ae88bc0b08)
---
 crypto/openssh/sshd-session.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/crypto/openssh/sshd-session.c b/crypto/openssh/sshd-session.c
index e8299c254567..ca35790149ac 100644
--- a/crypto/openssh/sshd-session.c
+++ b/crypto/openssh/sshd-session.c
@@ -217,8 +217,6 @@ mm_is_monitor(void)
 static void
 grace_alarm_handler(int sig)
 {
-	BLOCKLIST_NOTIFY(the_active_state, BLOCKLIST_AUTH_FAIL,
-	    "Grace period expired");
 	/*
 	 * Try to kill any processes that we have spawned, E.g. authorized
 	 * keys command helpers or privsep children.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202510160035.59G0Z4tX011650>