From owner-p4-projects@FreeBSD.ORG Sat Jul 15 14:09:24 2006 Return-Path: X-Original-To: p4-projects@freebsd.org Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id C9E0316A4DF; Sat, 15 Jul 2006 14:09:24 +0000 (UTC) X-Original-To: perforce@freebsd.org Delivered-To: perforce@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A2C0D16A4DA; Sat, 15 Jul 2006 14:09:24 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2954843D45; Sat, 15 Jul 2006 14:09:24 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from zion.baldwin.cx (zion.baldwin.cx [192.168.0.7]) (authenticated bits=0) by server.baldwin.cx (8.13.4/8.13.4) with ESMTP id k6FE9MIP022462; Sat, 15 Jul 2006 10:09:22 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Roman Divacky Date: Sat, 15 Jul 2006 10:03:28 -0400 User-Agent: KMail/1.9.1 References: <200607150905.k6F959IT031112@repoman.freebsd.org> In-Reply-To: <200607150905.k6F959IT031112@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200607151003.28710.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [192.168.0.1]); Sat, 15 Jul 2006 10:09:23 -0400 (EDT) X-Virus-Scanned: ClamAV 0.87.1/1599/Fri Jul 14 01:35:31 2006 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.1.0 X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on server.baldwin.cx Cc: Perforce Change Reviews Subject: Re: PERFORCE change 101643 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 15 Jul 2006 14:09:25 -0000 On Saturday 15 July 2006 05:05, Roman Divacky wrote: > http://perforce.freebsd.org/chv.cgi?CH=101643 > > Change 101643 by rdivacky@rdivacky_witten on 2006/07/15 09:04:22 > > Several things at once: > > o Change process_exit and process_exec function handlers prototype > to include struct image_params arg. Why did you add it to process_exit()? exit() doesn't have an imgp to pass, so this doesn't make sense. If you are doing it so you can use the same function for both, then use a wrapper in the exit() case or some such. -- John Baldwin