From owner-cvs-all  Thu Mar 15 13:43:42 2001
Delivered-To: cvs-all@freebsd.org
Received: from vega.dmnshq.net (vega.dmnshq.net [194.19.34.94])
	by hub.freebsd.org (Postfix) with SMTP
	id 4513037B718; Thu, 15 Mar 2001 13:43:36 -0800 (PST)
	(envelope-from eivind@vega.dmnshq.net)
Received: (from eivind@localhost)
	by vega.dmnshq.net (8.11.3/8.9.3) id f2FLhXQ96644;
	Thu, 15 Mar 2001 22:43:33 +0100 (CET)
	(envelope-from eivind)
Date: Thu, 15 Mar 2001 22:43:33 +0100
From: Eivind Eklund <eivind@FreeBSD.org>
To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Cc: Soren Schmidt <sos@freebsd.dk>, Ruslan Ermilov <ru@FreeBSD.org>
Subject: Re: cvs commit: src/sbin/atacontrol pathnames.h Makefile atacontrol.8         atacontrol.c
Message-ID: <20010315224333.A92574@thinksec.com>
References: <200103151928.f2FJSwi60381@freefall.freebsd.org> <200103152001.VAA73815@freebsd.dk> <20010315122435.C29888@fw.wintelcom.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5i
In-Reply-To: <20010315122435.C29888@fw.wintelcom.net>; from bright@wintelcom.net on Thu, Mar 15, 2001 at 12:24:35PM -0800
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

On Thu, Mar 15, 2001 at 12:24:35PM -0800, Alfred Perlstein wrote:
> * Soren Schmidt <sos@freebsd.dk> [010315 12:01] wrote:
> > It seems Ruslan Ermilov wrote:
> > > ru          2001/03/15 11:28:58 PST
> > > 
> > >   Modified files:
> > >     sbin/atacontrol      Makefile atacontrol.8 atacontrol.c 
> > >   Added files:
> > >     sbin/atacontrol      pathnames.h 
> > >   Log:
> > >   Make this compile with ${BDECFLAGS}, apply style(9), cleanup manpage.
> > >   
> > >   Revision  Changes    Path
> > >   1.2       +3 -1      src/sbin/atacontrol/Makefile
> > >   1.2       +45 -33    src/sbin/atacontrol/atacontrol.8
> > >   1.2       +111 -65   src/sbin/atacontrol/atacontrol.c
> > 
> > I would have liked you to pass this by me first, now I have to go
> > through the hell of merging this with what I got here.
> 
> Style cleanups on other people's _code_ should either be mentioned
> to the author via mail, perferably with a diff attached.

... or mentioned to the author via some other medium.

Committing massive style changes to clearly lively code without
coordinating with the other people touching that code is NOT
OK, no matter if the person keeping it lively is the original
author or not.

Eivind.

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message