From nobody Sun Oct 26 16:53:05 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cvjPr73lKz6DYnT for ; Sun, 26 Oct 2025 16:53:20 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cvjPr1x68z3qht for ; Sun, 26 Oct 2025 16:53:20 +0000 (UTC) (envelope-from asomers@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=freebsd.org (policy=none); spf=pass (mx1.freebsd.org: domain of asomers@gmail.com designates 209.85.208.51 as permitted sender) smtp.mailfrom=asomers@gmail.com Received: by mail-ed1-f51.google.com with SMTP id 4fb4d7f45d1cf-63c489f1e6cso6197847a12.1 for ; Sun, 26 Oct 2025 09:53:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761497598; x=1762102398; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=DY35La6reeaN6J9dgikuoMXdAhBU+7orS3bNR6INwcY=; b=wifFLwx8+u/knfn2q6kv09+PEhaY05rdmm77eSFE71WJ8ht83vzF47SNN/FTgRwauk ZDedyi6kg7jucGRYD2f9dYlKgylK2n+FLyY3G0MMknF+korDdyEm3zVn51d3hHv2qX8m /Na0m7NJORlnUxMtkySz1dfBqC0g4DcCLvBY2rVCfKxQ1YRtCn4ClaEIRge7ZOE5Fsdx IkwaL6LmwfWphXZSKBJvufHZcRVN4KuUWFYwmxiaNwdwnzQgAbM8GZ8bZX9gPo+c5Gt6 fFDWVIrswBTv8eKZJGot693KMs8TMxCwHIfxCtclH7tdsbiWCrM/l3/3zpcO11v2jqD2 S7vg== X-Forwarded-Encrypted: i=1; AJvYcCUrF7Ki97+aeQBrViPBw2sifhyDyV8HbM9xsLGY4sdz+5Gud8Sac1I6ZbeqOMjP0OZ6tz1OCTOJsMKCm/qQfRBsZ8NavA==@freebsd.org X-Gm-Message-State: AOJu0YwIAkN+m4sRv00Z90g9sELmjXbzTBKlh8dHfRrQWUNlZfMCn5OI HJo9xQz9AJQD8bgMfgKjA7TY4n8AFNm6O+qZlj/5Ze5a1roNowysp7SWZnSMdlcGE9wj8WWtXw0 3+9rvoIcTckixrEDL54mTyww9IC0s/rw= X-Gm-Gg: ASbGncumbukXchGylFYk1OlnmrzweFFnbh3Q3ekLPQSesVJ88EicL1K6xQghwCBgp38 IPoOow3UW4qYDKHm9f2DMiFNriuVI+qqVsrY1KX8JQUYLx7gWcXsl1L8OUJe3/a6QCuS8rZpAFw StaijWebJCHd8n63mBFbUnWCDGg2rvSWO1AUCilq0J5TzblJKUCc7fPUykxd1iih1UHsB2b3JQ5 Hr3LVoTIG32fTt/Q6pvP3QdL587Ed4L1i9HwlFW1hX79xJPWJykWsSnblx/Nk3ZTAutxkj4RO6m XgtZfA== X-Google-Smtp-Source: AGHT+IGaD8vP7cX5roIPxcxY2ZnG/Ok6rFaIadf9Zt1v5QxVbfg64RTpBSJC8Dflb85Pjukh8qxT7yftn0hZi221RGw= X-Received: by 2002:a05:6402:4cd:b0:62f:1366:46e8 with SMTP id 4fb4d7f45d1cf-63e5e9054e8mr5844020a12.7.1761497597665; Sun, 26 Oct 2025 09:53:17 -0700 (PDT) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 References: <202510231341.59NDf5as007410@gitrepo.freebsd.org> In-Reply-To: From: Alan Somers Date: Sun, 26 Oct 2025 10:53:05 -0600 X-Gm-Features: AWmQ_bnrPDOhE2PXksaIPEDlKOAk7QIlfn_fJXnY7jwtZIEHCLc9iR3s4KOqCAQ Message-ID: Subject: Re: git: 6d408ac49073 - main - fusefs: add a regression test for a cluster_read bug To: Konstantin Belousov Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: multipart/alternative; boundary="00000000000094e34e0642129e6e" X-Spamd-Bar: -- X-Spamd-Result: default: False [-2.89 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-0.999]; NEURAL_HAM_SHORT(-1.00)[-0.995]; FORGED_SENDER(0.30)[asomers@freebsd.org,asomers@gmail.com]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; DMARC_POLICY_SOFTFAIL(0.10)[freebsd.org : SPF not aligned (relaxed), No valid DKIM,none]; RCPT_COUNT_THREE(0.00)[4]; RCVD_TLS_LAST(0.00)[]; FREEMAIL_TO(0.00)[gmail.com]; ARC_NA(0.00)[]; RCVD_COUNT_ONE(0.00)[1]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; MISSING_XM_UA(0.00)[]; FROM_HAS_DN(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-main@freebsd.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; FROM_NEQ_ENVFROM(0.00)[asomers@freebsd.org,asomers@gmail.com]; FREEFALL_USER(0.00)[asomers]; MLMMJ_DEST(0.00)[dev-commits-src-main@freebsd.org]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.208.51:from]; R_DKIM_NA(0.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; RCVD_IN_DNSWL_NONE(0.00)[209.85.208.51:from] X-Rspamd-Queue-Id: 4cvjPr1x68z3qht --00000000000094e34e0642129e6e Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Oct 24, 2025 at 2:13=E2=80=AFAM Konstantin Belousov wrote: > On Thu, Oct 23, 2025 at 01:41:05PM +0000, Alan Somers wrote: > > The branch main has been updated by asomers: > > > > URL: > https://cgit.FreeBSD.org/src/commit/?id=3D6d408ac490730614b3ed0ebd3caffcd= 23f303fb4 > > > > commit 6d408ac490730614b3ed0ebd3caffcd23f303fb4 > > Author: Alan Somers > > AuthorDate: 2025-10-23 13:40:56 +0000 > > Commit: Alan Somers > > CommitDate: 2025-10-23 13:40:56 +0000 > > > > fusefs: add a regression test for a cluster_read bug > > > > VOP_BMAP is purely advisory. If VOP_BMAP returns an error during > > readahead, cluster_read should still succeed, because the actual da= ta > > was still read just fine. > No, VOP_BMAP() is not advisory. But read-ahead beyond the first buffer i= s. > The BMAP in question is to translate lblk for read-ahead buffer. > > The FUSE_WRITE request _always_ includes the file's nodeid and offset. So unlike, say, UFS, FUSE_BMAP is only used to make decisions about clustering, to compute the amount of readahead. So I suppose I should've said that "FUSE_BMAP is purely advisory". Thanks for the correction. --00000000000094e34e0642129e6e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Fri, Oct 24, 2025 at 2:13=E2=80=AFAM Konst= antin Belousov <kostikbel@gmail.c= om> wrote:
https://= cgit.FreeBSD.org/src/commit/?id=3D6d408ac490730614b3ed0ebd3caffcd23f303fb4<= /a>
>
> commit 6d408ac490730614b3ed0ebd3caffcd23f303fb4
> Author:=C2=A0 =C2=A0 =C2=A0Alan Somers <asomers@FreeBSD.org>
> AuthorDate: 2025-10-23 13:40:56 +0000
> Commit:=C2=A0 =C2=A0 =C2=A0Alan Somers <asomers@FreeBSD.org>
> CommitDate: 2025-10-23 13:40:56 +0000
>
>=C2=A0 =C2=A0 =C2=A0fusefs: add a regression test for a cluster_read bu= g
>=C2=A0 =C2=A0 =C2=A0
>=C2=A0 =C2=A0 =C2=A0VOP_BMAP is purely advisory.=C2=A0 If VOP_BMAP retu= rns an error during
>=C2=A0 =C2=A0 =C2=A0readahead, cluster_read should still succeed, becau= se the actual data
>=C2=A0 =C2=A0 =C2=A0was still read just fine.
No, VOP_BMAP() is not advisory.=C2=A0 But read-ahead beyond the first buffe= r is.
The BMAP in question is to translate lblk for read-ahead buffer.

=C2=A0
The FUSE_WRITE request _always_ inclu= des the file's nodeid and offset.=C2=A0=20 So unlike, say, UFS, FUSE_BMAP is only used to make decisions about=20 clustering, to compute the amount of readahead.=C2=A0 So I suppose I=20 should've said that "FUSE_BMAP is purely advisory".=C2=A0 Tha= nks for the correction.
--00000000000094e34e0642129e6e--