From owner-freebsd-hackers@FreeBSD.ORG Sun Oct 28 10:55:27 2012 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 51C48EAA; Sun, 28 Oct 2012 10:55:27 +0000 (UTC) (envelope-from gabor@kovesdan.org) Received: from server.mypc.hu (server.mypc.hu [87.229.73.95]) by mx1.freebsd.org (Postfix) with ESMTP id EF7C58FC12; Sun, 28 Oct 2012 10:55:26 +0000 (UTC) Received: from server.mypc.hu (localhost [127.0.0.1]) by server.mypc.hu (Postfix) with ESMTP id 3284F14E6F68; Sun, 28 Oct 2012 11:55:19 +0100 (CET) X-Virus-Scanned: amavisd-new at !change-mydomain-variable!.example.com Received: from server.mypc.hu ([127.0.0.1]) by server.mypc.hu (server.mypc.hu [127.0.0.1]) (amavisd-new, port 10024) with LMTP id yizdYkaoO5BK; Sun, 28 Oct 2012 11:55:18 +0100 (CET) Received: from [192.168.1.100] (5403A6BE.catv.pool.telekom.hu [84.3.166.190]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by server.mypc.hu (Postfix) with ESMTPSA id 15B0C14E5F21; Sun, 28 Oct 2012 11:55:18 +0100 (CET) Message-ID: <508D0F11.1060203@kovesdan.org> Date: Sun, 28 Oct 2012 11:55:13 +0100 From: Gabor Kovesdan User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:14.0) Gecko/20120713 Thunderbird/14.0 MIME-Version: 1.0 To: hiren panchasara Subject: Re: Porting patch(1) from NetBSD to FreeBSD (was Re: FreeBSD in Google Code-In 2012? You can help too!) References: In-Reply-To: X-Enigmail-Version: 1.4.4 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Mailman-Approved-At: Sun, 28 Oct 2012 11:19:34 +0000 Cc: freebsd-hackers@freebsd.org, Pedro Giffuni X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Oct 2012 10:55:27 -0000 Em 27-10-2012 23:17, hiren panchasara escreveu: > Hi Pedro / List, > > I am not part of google summer of code but I've tried to port patch(1) from > NetBSD into FreeBSD head. I hope that is okay. > > Patching was trivial and It _seems_ to be working fine. > > I would appreciate any ideas around how to test the changes and how to > proceed further. Hi Hiren, good to hear that someone is working on this! However, porting these utilies is much tougher than it apparently seems. There are much more criteria than just it compiles and works. More specifically, you should make sure that: - It is feature-complete and has at least the features that are present in the current patch. - Features are actually compatible and do the same. The same set of command-line options have to produce identical output. - Performance is not behind the current implementation. - It works fine with multi-byte locales. - As mentioned by someone else, it should be available as a port for testers. And once the above points seem to be ok, you should ask the portmgr team to do a package build with it. It may reveal some problems that you couldn't produce earlier. - And as seen in BSD grep, all of this above may not be enough, there may still be some undiscovered bugs. :) So it should co-exist with the current patch for some time, first as a secondary one and then as the default and only then should the current patch be removed. BSD sort has gone through all of this but BSD grep is still not completed. These utilities are apparently simple but because of their importance, they need to be near to flawless so this makes it a good challenge. I hope you will enjoy hacking and hope you can make some progress in this! Gabor